Skip to content

CLN: Remove deprecated method #22324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

CLN: Remove deprecated method #22324

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6b8fedd
Remove outdated docs
alimcmaster1 Aug 13, 2018
53bc144
Remove deprecated method cdate_range
alimcmaster1 Aug 13, 2018
376e48c
Remove unrequired-doc
alimcmaster1 Aug 13, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions pandas/core/indexes/datetimes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1815,11 +1815,6 @@ def cdate_range(start=None, end=None, periods=None, freq='C', tz=None,
Normalize start/end dates to midnight before generating date range
name : string, default None
Name of the resulting DatetimeIndex
weekmask : string, Default 'Mon Tue Wed Thu Fri'
weekmask of valid business days, passed to ``numpy.busdaycalendar``
holidays : list
list/array of dates to exclude from the set of valid business days,
passed to ``numpy.busdaycalendar``
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you look at the implementation, although they may not be explicit parameters, but they should be documented. Not sure if plain removal is the right move here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh apologies I looked at bdate_range and saw they where optional params there opposed to kwargs. It's a deprecated method anyway, but how about documenting it something like below So its clear they are kwargs?

closed : string, default None
    Make the interval closed with respect to the given frequency to
    the 'left', 'right', or both sides (None)
**weekmask : string, Default 'Mon Tue Wed Thu Fri'
    weekmask of valid business days, passed to ``numpy.busdaycalendar``
**holidays : list
    list/array of dates to exclude from the set of valid business days,
    passed to ``numpy.busdaycalendar``

Copy link
Member

@gfyoung gfyoung Aug 13, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I'll do you one better. Let's just remove it (it's been long enough).

How does that sound?

closed : string, default None
Make the interval closed with respect to the given frequency to
the 'left', 'right', or both sides (None)
Expand Down