Skip to content

Replace tar_csv.tar.gz with gzipped tar #22269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 17, 2018
Merged

Replace tar_csv.tar.gz with gzipped tar #22269

merged 1 commit into from
Aug 17, 2018

Conversation

ginggs
Copy link
Contributor

@ginggs ginggs commented Aug 10, 2018

tar was not compressed previously

tar was not compressed previously
@jreback
Copy link
Contributor

jreback commented Aug 10, 2018

cc @gfyoung

@jreback
Copy link
Contributor

jreback commented Aug 10, 2018

(pandas) bash-3.2$ ls pandas/tests/io/parser/data/
iris.csv                salaries.csv.bz2        salaries.csv.zip        tar_csv.tar             test1.csv.bz2           test_mmap.csv           tips.csv.gz             utf16_ex_small.zip
items.jsonl             salaries.csv.gz         sauron.SHIFT_JIS.csv    tar_csv.tar.gz          test1.csv.gz            tips.csv                unicode_series.csv
salaries.csv            salaries.csv.xz         sub_char.csv            test1.csv               test2.csv               tips.csv.bz2            utf16_ex.txt

?

@ginggs
Copy link
Contributor Author

ginggs commented Aug 10, 2018

@jreback try ls -l, you'll see tar_csv.tar and tar_csv.tar.gz are both 10240 bytes in size.

@gfyoung gfyoung added IO CSV read_csv, to_csv Testing pandas testing functions or related to the test suite IO Data IO issues that don't fit into a more specific label and removed IO CSV read_csv, to_csv labels Aug 10, 2018
@codecov
Copy link

codecov bot commented Aug 10, 2018

Codecov Report

Merging #22269 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #22269   +/-   ##
=======================================
  Coverage   92.08%   92.08%           
=======================================
  Files         169      169           
  Lines       50694    50694           
=======================================
  Hits        46682    46682           
  Misses       4012     4012
Flag Coverage Δ
#multiple 90.49% <ø> (ø) ⬆️
#single 42.34% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c2b658...9bc8d7d. Read the comment docs.

@WillAyd WillAyd merged commit e90b77d into pandas-dev:master Aug 17, 2018
@WillAyd
Copy link
Member

WillAyd commented Aug 17, 2018

Thanks @ginggs !

@ginggs ginggs deleted the gz-file-not-gzip branch August 17, 2018 12:25
Moons08 pushed a commit to Moons08/pandas that referenced this pull request Aug 17, 2018
Sup3rGeo pushed a commit to Sup3rGeo/pandas that referenced this pull request Oct 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IO Data IO issues that don't fit into a more specific label Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants