BUG: raise KeyError if MultiIndex.get_loc_level is asked unused label #22230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #22230 +/- ##
==========================================
+ Coverage 92.07% 92.07% +<.01%
==========================================
Files 169 169
Lines 50683 50684 +1
==========================================
+ Hits 46666 46668 +2
+ Misses 4017 4016 -1
Continue to review full report at Codecov.
|
jreback
requested changes
Aug 7, 2018
| @@ -271,6 +271,10 @@ def test_get_loc_level(): | |||
| assert new_index is None | |||
|
|
|||
| pytest.raises(KeyError, index.get_loc_level, (2, 2)) | |||
| # GH 22221: unused label | |||
There was a problem hiding this comment.
can you add the issue number here
There was a problem hiding this comment.
Do you mean repeat it below?
pandas/core/indexes/multi.py
Outdated
|
|
||
| if level > 0 or self.lexsort_depth == 0: | ||
| # Desired level is not sorted | ||
| locs = np.array(labels == code, dtype=bool) |
There was a problem hiding this comment.
I think you can pass copy=False here
|
can you also add the original OP test somewhere. |
jreback
requested changes
Aug 8, 2018
pandas/core/indexes/multi.py
Outdated
|
|
||
| if level > 0 or self.lexsort_depth == 0: | ||
| # Desired level is not sorted | ||
| locs = np.array(labels == code, dtype=bool) |
| @@ -271,6 +271,10 @@ def test_get_loc_level(): | |||
| assert new_index is None | |||
|
|
|||
| pytest.raises(KeyError, index.get_loc_level, (2, 2)) | |||
| # GH 22221: unused label | |||
toobaz
force-pushed
the
mi_get_loc_level_unused_22221
branch
from
ea539d8 to
31b55c4
Compare
jreback
approved these changes
Aug 9, 2018
|
thanks @toobaz |
Sup3rGeo
pushed a commit
to Sup3rGeo/pandas
that referenced
this pull request
Oct 1, 2018
…pandas-dev#22230) * BUG: raise KeyError if MultiIndex.get_loc_level is asked unused label closes pandas-dev#22221 * TST: test groupby.apply() with user-defined function returning an empty chunk * CLN: remove named lambda
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master -u -- "*.py" | flake8 --diff