Standardize special case in tz_conversion functions #22181
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #22181 +/- ##
=======================================
Coverage 92.06% 92.06%
=======================================
Files 169 169
Lines 50694 50694
=======================================
Hits 46671 46671
Misses 4023 4023
Continue to review full report at Codecov.
|
jreback
reviewed
Aug 7, 2018
pandas/_libs/tslibs/conversion.pyx
Outdated
| # Note: at least with cython 0.28.3, doing a lookup `[0]` in the next | ||
| # line is sensitive to the declared return type of _tz_convert_dst; | ||
| # if it is declared as returning ndarray[int64_t], a compile-time error | ||
| # is raised. | ||
| return _tz_convert_dst(arr, tz2, to_utc=False)[0] | ||
|
|
||
|
|
||
| cdef inline int64_t[:] _tz_convert(int64_t[:] vals, object tz, bint to_utc): |
There was a problem hiding this comment.
can you name this something else, it is pretty confusing
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ATM
_tz_convert_dsthandles iteration and masking differently (and more complicated-ly) than other related functions. AFAICT the reasoning is that this implementation is performant when the passedvalshave a high proportion ofiNaTs.By changing this special case to conform to the standard pattern, we allow other functions to call this without having to do any special casting, generally simplify things, and open the door to de-duplicating these functions (which this PR also starts doing by implementing
_tz_convert)git diff upstream/master -u -- "*.py" | flake8 --diff