BUG: ensuring that np.asarray() simple handles data as objects and doesn't… #22161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #22161 +/- ##
=======================================
Coverage 92.08% 92.08%
=======================================
Files 169 169
Lines 50704 50704
=======================================
Hits 46691 46691
Misses 4013 4013
Continue to review full report at Codecov.
|
jreback
requested changes
Aug 1, 2018
| @@ -134,7 +134,7 @@ def _ensure_data(values, dtype=None): | |||
| return values, dtype, 'int64' | |||
|
|
|||
| # we have failed, return object | |||
| values = np.asarray(values) | |||
| values = np.asarray(values, dtype=np.object) | |||
There was a problem hiding this comment.
so we actually should prob use pandas.core.dtypes.cast.construct_1d_array_preserving_na which is even better here. further pls run the performance suite for things like factorize, value_counts, isin, this a very performance sensitive section.
There was a problem hiding this comment.
@jreback Actually, pandas.core.dtypes.cast.construct_1d_ndarray_preserving_na would not work for two reasons:
- For
[42, 's']it returnsarray(['42', 's'], dtype='<U11')and not the wantedarray([42, 's'], dtype=object)), not sure this is the intended behavior of the function though - For
[np.nan]it returnsarray([nan], dtype=float64)which leads toresult[0] is np.nanbeing False, but we would like to keep the id of the object.
jreback
added
the
Compat
|
Hello @realead! Thanks for updating the PR. Cheers ! There are no PEP8 issues in this Pull Request. 🍻 Comment last updated on August 10, 2018 at 09:50 Hours UTC |
realead
changed the title
|
For asv continuous -f 1.1 upstream/master HEAD -b ^series_methods -b ^algorithms the result was:
|
|
can you rebase and run perf tests on algos. I find ever small changes sometimes can really impact perf here. |
jreback
requested changes
Aug 9, 2018
doc/source/whatsnew/v0.24.0.txt
Outdated
| @@ -573,6 +573,5 @@ Other | |||
| - :meth: `~pandas.io.formats.style.Styler.background_gradient` now takes a ``text_color_threshold`` parameter to automatically lighten the text color based on the luminance of the background color. This improves readability with dark background colors without the need to limit the background colormap range. (:issue:`21258`) | |||
| - Require at least 0.28.2 version of ``cython`` to support read-only memoryviews (:issue:`21688`) | |||
| - :meth: `~pandas.io.formats.style.Styler.background_gradient` now also supports tablewise application (in addition to rowwise and columnwise) with ``axis=None`` (:issue:`15204`) | |||
| - | |||
| - | |||
| - :meth:`pandas.core.algorithms.isin` avoids spurious casting for lists (:issue:`22160`) | |||
There was a problem hiding this comment.
ok , this is an internal, routine, ok removing this whatsnew note.
…esn't try to do smart things (GH22160)
…s adjusting the test cases
|
There were no performance changes:
|
jreback
added
Bug
Indexing
|
@realead ok with this, can you remove the whatsnew note. ping on green. |
jreback
approved these changes
Aug 9, 2018
|
Close/Open to trigger CI-run |
|
thanks @realead |
Sup3rGeo
pushed a commit
to Sup3rGeo/pandas
that referenced
this pull request
Oct 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… try to do smart things (GH22160)
git diff upstream/master -u -- "*.py" | flake8 --diff