[TST] make xfails strict #22139
Merged
[TST] make xfails strict #22139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
requested changes
Jul 31, 2018
| @@ -142,6 +142,7 @@ def test_custom_asserts(self): | |||
|
|
|||
| class TestConstructors(BaseJSON, base.BaseConstructorsTests): | |||
|
|
|||
| # TODO: Should this be pytest.mark.skip? | |||
There was a problem hiding this comment.
yeah u can change to skip (and similar ones)
| @@ -83,7 +83,7 @@ def test_nulls(idx): | |||
| idx.isna() | |||
|
|
|||
|
|
|||
| @pytest.mark.xfail | |||
| @pytest.mark.xfail(strict=True) | |||
There was a problem hiding this comment.
Sure, will try to sort that out. Also waiting to see if anything fails on the CI that passed locally.
| @@ -212,7 +212,6 @@ def test_parallel_coordinates(self, iris): | |||
| with tm.assert_produces_warning(FutureWarning): | |||
| parallel_coordinates(df, 'Name', colors=colors) | |||
|
|
|||
| @pytest.mark.xfail(reason="unreliable test") | |||
| def test_parallel_coordinates_with_sorted_labels(self): | |||
Codecov Report
@@ Coverage Diff @@
## master #22139 +/- ##
==========================================
- Coverage 92.07% 92.06% -0.01%
==========================================
Files 170 170
Lines 50688 50689 +1
==========================================
- Hits 46671 46669 -2
- Misses 4017 4020 +3
Continue to review full report at Codecov.
|
jreback
approved these changes
Aug 1, 2018
|
thanks, ideally also update the contributing.rst docs where we use xfail as an example to include the strict param. |
dberenbaum
pushed a commit
to dberenbaum/pandas
that referenced
this pull request
Aug 3, 2018
Sup3rGeo
pushed a commit
to Sup3rGeo/pandas
that referenced
this pull request
Oct 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This leaves untouched xfails with reasons like "flaky on 3.7" and a few where the test itself is just a
pass.In the process a handful of previously xfailed cases are no longer xfailed.