Skip to content

Lint configuration followup #22123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 30, 2018
Merged

Lint configuration followup #22123

merged 1 commit into from
Jul 30, 2018

Conversation

mroeschke
Copy link
Member

@mroeschke mroeschke commented Jul 30, 2018 •
edited
Loading

Post #22075

  • Ran scripts/convert_deps.py
  • Documented flake8 checks we are ignoring

cc @jreback

jreback
jreback approved these changes Jul 30, 2018
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm merge on green

@codecov
Copy link

codecov bot commented Jul 30, 2018 •
edited
Loading

Codecov Report

Merging #22123 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #22123   +/-   ##
=======================================
  Coverage   92.07%   92.07%           
=======================================
  Files         170      170           
  Lines       50690    50690           
=======================================
  Hits        46672    46672           
  Misses       4018     4018
Flag Coverage Δ
#multiple 90.48% <ø> (ø) ⬆️
#single 42.31% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d30c4a0...5ceed95. Read the comment docs.

@jreback jreback added the Code Style Code style, linting, code_checks label Jul 30, 2018
@jreback jreback added this to the 0.24.0 milestone Jul 30, 2018
@jreback jreback merged commit a5e5ca6 into pandas-dev:master Jul 30, 2018
@jreback
Copy link
Contributor

jreback commented Jul 30, 2018

thanks!

@mroeschke mroeschke deleted the linting_followup branch July 30, 2018 15:21
dberenbaum pushed a commit to dberenbaum/pandas that referenced this pull request Aug 3, 2018
@mroeschke @dberenbaum
Lint configuration followup (pandas-dev#22123)
bcf4933
Sup3rGeo pushed a commit to Sup3rGeo/pandas that referenced this pull request Oct 1, 2018
@mroeschke
Lint configuration followup (pandas-dev#22123)
5768f33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
Code Style Code style, linting, code_checks
Projects
None yet
Milestone
0.24.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mroeschke @jreback