-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
DOC: Fix spaces and brackets in ValueError message for option_context. #22121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@pvanmulbregt this looks good, Travis error is unrelated. Can you push again to make it try again? |
@jbrockmendel: "push again" as in "$ git push -v -f origin"? That tells me "Everything up-to-date". Or did you mean something else? |
Yah, usually I find a or something to fix to get around that. |
Codecov Report
@@ Coverage Diff @@
## master #22121 +/- ##
=======================================
Coverage 92.07% 92.07%
=======================================
Files 170 170
Lines 50690 50690
=======================================
Hits 46672 46672
Misses 4018 4018
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #22121 +/- ##
=======================================
Coverage 92.07% 92.07%
=======================================
Files 170 170
Lines 50690 50690
=======================================
Hits 46672 46672
Misses 4018 4018
Continue to review full report at Codecov.
|
thanks @pvanmulbregt |
Add a missing space and changed a parenthesis to a bracket in the message of the ValueError raised whenever the
args
inoption_context(*args)
don't meet requirements.'Need to invoke asoption_context(pat, val, [(pat, val), ...)).'
->
'Need to invoke as option_context(pat, val, [(pat, val), ...]).'
git diff upstream/master -u -- "*.py" | flake8 --diff