Skip to content

DOC: Fix spaces and brackets in ValueError message for option_context. #22121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 30, 2018

Conversation

pvanmulbregt
Copy link
Contributor

Add a missing space and changed a parenthesis to a bracket in the message of the ValueError raised whenever the args in option_context(*args) don't meet requirements.
'Need to invoke asoption_context(pat, val, [(pat, val), ...)).'
->
'Need to invoke as option_context(pat, val, [(pat, val), ...]).'

  • tests added / passed
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff

@jbrockmendel
Copy link
Member

@pvanmulbregt this looks good, Travis error is unrelated. Can you push again to make it try again?

@pvanmulbregt
Copy link
Contributor Author

@jbrockmendel: "push again" as in "$ git push -v -f origin"? That tells me "Everything up-to-date". Or did you mean something else?

@jbrockmendel
Copy link
Member

That tells me "Everything up-to-date". Or did you mean something else?

Yah, usually I find a or something to fix to get around that.

@codecov
Copy link

codecov bot commented Jul 30, 2018

Codecov Report

Merging #22121 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #22121   +/-   ##
=======================================
  Coverage   92.07%   92.07%           
=======================================
  Files         170      170           
  Lines       50690    50690           
=======================================
  Hits        46672    46672           
  Misses       4018     4018
Flag Coverage Δ
#multiple 90.48% <0%> (ø) ⬆️
#single 42.31% <0%> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/config.py 87.17% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d30c4a0...52a8210. Read the comment docs.

@codecov
Copy link

codecov bot commented Jul 30, 2018

Codecov Report

Merging #22121 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #22121   +/-   ##
=======================================
  Coverage   92.07%   92.07%           
=======================================
  Files         170      170           
  Lines       50690    50690           
=======================================
  Hits        46672    46672           
  Misses       4018     4018
Flag Coverage Δ
#multiple 90.48% <ø> (ø) ⬆️
#single 42.31% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/config.py 87.17% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d30c4a0...52a8210. Read the comment docs.

@jreback jreback added the Docs label Jul 30, 2018
@jreback jreback added this to the 0.24.0 milestone Jul 30, 2018
@jreback jreback merged commit e1809f7 into pandas-dev:master Jul 30, 2018
@jreback
Copy link
Contributor

jreback commented Jul 30, 2018

thanks @pvanmulbregt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants