Skip to content

remove cnp usage from sas.pyx #22111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 29, 2018
Merged

remove cnp usage from sas.pyx #22111

merged 2 commits into from
Jul 29, 2018

Conversation

jbrockmendel
Copy link
Member

Building this particular file will no longer emit the numpy 1.7 deprecation warning.

@topper-123
Copy link
Contributor

FYI, there is a build bug currently, will be fixed when #22110 is pulled in.

@codecov
Copy link

codecov bot commented Jul 29, 2018

Codecov Report

Merging #22111 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #22111   +/-   ##
=======================================
  Coverage   92.06%   92.06%           
=======================================
  Files         170      170           
  Lines       50705    50705           
=======================================
  Hits        46680    46680           
  Misses       4025     4025
Flag Coverage Δ
#multiple 90.47% <ø> (ø) ⬆️
#single 42.31% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b7a08b...763ae49. Read the comment docs.

@jreback jreback added Build Library building on various platforms IO SAS SAS: read_sas labels Jul 29, 2018
@jreback jreback added this to the 0.24.0 milestone Jul 29, 2018
@jreback jreback merged commit 21cbca6 into pandas-dev:master Jul 29, 2018
@jreback
Copy link
Contributor

jreback commented Jul 29, 2018

thanks!

@jbrockmendel jbrockmendel deleted the cysas branch August 8, 2018 15:53
Sup3rGeo pushed a commit to Sup3rGeo/pandas that referenced this pull request Oct 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build Library building on various platforms IO SAS SAS: read_sas
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants