DOC: Clarify check_like behavior in assert_frame_equal #22106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
DeanLa
commented
Jul 28, 2018
•
DeanLa
commented
- closes pd.testing.assert_frame_equal check_like not working like expected #22052
WillAyd
requested changes
Jul 28, 2018
pandas/util/testing.py
Outdated
| @@ -1348,7 +1348,9 @@ def assert_frame_equal(left, right, check_dtype=True, | |||
| check_categorical : bool, default True | |||
| Whether to compare internal Categorical exactly. | |||
| check_like : bool, default False | |||
| If true, ignore the order of rows & columns | |||
| If true, ignore the order of rows & columns. | |||
Changed capitalization true -> True
Codecov Report
@@ Coverage Diff @@
## master #22106 +/- ##
==========================================
+ Coverage 92.06% 92.07% +0.01%
==========================================
Files 170 170
Lines 50705 50688 -17
==========================================
- Hits 46680 46671 -9
+ Misses 4025 4017 -8
Continue to review full report at Codecov.
|
jreback
requested changes
Jul 29, 2018
pandas/util/testing.py
Outdated
| @@ -1348,7 +1348,9 @@ def assert_frame_equal(left, right, check_dtype=True, | |||
| check_categorical : bool, default True | |||
| Whether to compare internal Categorical exactly. | |||
| check_like : bool, default False | |||
| If true, ignore the order of rows & columns | |||
| If True, ignore the order of rows & columns. | |||
There was a problem hiding this comment.
can you change rows -> index (then don't need the work Index on next line), just use index
jreback
added
Testing
rows -> index
|
Changed as requested |
WillAyd
reviewed
Jul 30, 2018
pandas/util/testing.py
Outdated
| @@ -1348,7 +1348,9 @@ def assert_frame_equal(left, right, check_dtype=True, | |||
| check_categorical : bool, default True | |||
| Whether to compare internal Categorical exactly. | |||
| check_like : bool, default False | |||
| If true, ignore the order of rows & columns | |||
| If True, ignore the order of index & columns. | |||
| Note: row labels must match their respective rows | |||
row -> index
jreback
approved these changes
Jul 31, 2018
|
lgtm. @WillAyd merge when satisfied. |
|
Thanks @DeanLa ! |
dberenbaum
pushed a commit
to dberenbaum/pandas
that referenced
this pull request
Aug 3, 2018
Sup3rGeo
pushed a commit
to Sup3rGeo/pandas
that referenced
this pull request
Oct 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.