Skip to content

CLN: Old helper functions #22104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 29, 2018
Merged

Conversation

mroeschke
Copy link
Member

It appears that these functions were helpers at one point in the past, but they don't appear anywhere in the codebase now (and are not publicly documented).

I think they are safe to blow away, although they exist the public namespace.

@jbrockmendel
Copy link
Member

Tests.io.test_sql needs format

@jbrockmendel
Copy link
Member

Although the name makes grepping for it pretty much impossible

@codecov
Copy link

codecov bot commented Jul 29, 2018

Codecov Report

Merging #22104 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #22104      +/-   ##
==========================================
+ Coverage   92.06%   92.06%   +<.01%     
==========================================
  Files         170      170              
  Lines       50705    50691      -14     
==========================================
- Hits        46680    46669      -11     
+ Misses       4025     4022       -3
Flag Coverage Δ
#multiple 90.47% <100%> (ø) ⬆️
#single 42.31% <100%> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/reshape/util.py 100% <ø> (+9.67%) ⬆️
pandas/core/tools/datetimes.py 84.78% <100%> (-0.44%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b7a08b...d88151f. Read the comment docs.

@jreback jreback added this to the 0.24.0 milestone Jul 29, 2018
@jreback jreback merged commit e8e078f into pandas-dev:master Jul 29, 2018
@jreback
Copy link
Contributor

jreback commented Jul 29, 2018

thanks @mroeschke

@mroeschke mroeschke deleted the clean_unused_helpers branch July 29, 2018 18:15
Sup3rGeo pushed a commit to Sup3rGeo/pandas that referenced this pull request Oct 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CLN/DEPR: Undocumented, old helper functions
3 participants