Remove unused cimports, fix #22067 #22087
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbrockmendel
commented
Jul 27, 2018
| cdef int64_t _ordinal_from_fields(year, month, quarter, day, | ||
| hour, minute, second, freq): | ||
| cdef int64_t _ordinal_from_fields(int year, int month, quarter, int day, | ||
| int hour, int minute, int second, freq): |
There was a problem hiding this comment.
This is what fixed 22067. year and month were getting an Int64Index.
jreback
requested changes
Jul 28, 2018
| @@ -1920,8 +1920,8 @@ class Period(_Period): | |||
| return cls._from_ordinal(ordinal, freq) | |||
|
|
|||
|
|
|||
| cdef int64_t _ordinal_from_fields(year, month, quarter, day, | |||
| hour, minute, second, freq): | |||
| cdef int64_t _ordinal_from_fields(int year, int month, quarter, int day, | |||
There was a problem hiding this comment.
does quarter not need a type?
|
minor comments and pls rebase |
|
Hello @jbrockmendel! Thanks for updating the PR. Cheers ! There are no PEP8 issues in this Pull Request. 🍻 Comment last updated on July 29, 2018 at 20:57 Hours UTC |
Codecov Report
@@ Coverage Diff @@
## master #22087 +/- ##
=======================================
Coverage 92.07% 92.07%
=======================================
Files 170 170
Lines 50690 50690
=======================================
Hits 46672 46672
Misses 4018 4018
Continue to review full report at Codecov.
|
jreback
requested changes
Jul 29, 2018
| # GH#22067, check we don't get warnings about silently ignored errors | ||
| dti = date_range('2017-01-01', '2018-01-01', freq='B') | ||
|
|
||
| c = StringIO() |
|
Ping |
jreback
approved these changes
Jul 30, 2018
|
thanks! |
dberenbaum
pushed a commit
to dberenbaum/pandas
that referenced
this pull request
Aug 3, 2018
Sup3rGeo
pushed a commit
to Sup3rGeo/pandas
that referenced
this pull request
Oct 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22067, but no clear way to test it.