-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
fix for TypeError: unorderable types" in when using set_index with multiple column names #22072
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
af2ab19
BUG: Fix for TypeError: unorderable types" for multi index (#15457)
dickreuter 9bf7262
revert to test with dictionary
dickreuter bcea58b
pylint fixes, new test
dickreuter 42f093d
text correction
dickreuter bba1e9c
changes as per comments
dickreuter 1b3959e
revert changes
dickreuter 10ed01a
better description
dickreuter 801803a
more fixes
dickreuter 8daf9e6
change in doc as per comments
4cd3c0c
text change
c45705c
additional text changes
927f24f
Revert "additional text changes"
dickreuter 213c4ea
text fix
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -463,3 +463,12 @@ def test_tuples_with_name_string(): | |
pd.Index(li, name='abc') | ||
with pytest.raises(ValueError): | ||
pd.Index(li, name='a') | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can you undo the change in this file? (it's extraneous to your PR) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @gfyoung (unless I'm wrong) this comment ended up showing here by mistake? |
||
|
||
def test_from_tuples_with_tuple_label(): | ||
# GH 15457 | ||
expected = pd.DataFrame([[2, 1, 2], [4, (1, 2), 3]], | ||
columns=['a', 'b', 'c']).set_index(['a', 'b']) | ||
idx = pd.MultiIndex.from_tuples([(2, 1), (4, (1, 2))], names=('a', 'b')) | ||
result = pd.DataFrame([2, 3], columns=['c'], index=idx) | ||
tm.assert_frame_equal(expected, result) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add the issue reference