Skip to content

CLN: remove F821 flake8 error in test case #22009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 22, 2018

Conversation

holymonson
Copy link
Contributor

Kill flake8 error: F821 undefined name 'unicode'
compat.text_type == unicode if PY2

Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov
Copy link

codecov bot commented Jul 21, 2018

Codecov Report

Merging #22009 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #22009   +/-   ##
=======================================
  Coverage   91.99%   91.99%           
=======================================
  Files         167      167           
  Lines       50578    50578           
=======================================
  Hits        46530    46530           
  Misses       4048     4048
Flag Coverage Δ
#multiple 90.4% <ø> (ø) ⬆️
#single 42.17% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 322dbf4...9a00a35. Read the comment docs.

@jorisvandenbossche jorisvandenbossche changed the title frame: kill F821 error in test case CLN: remove F821 flake8 error in test case Jul 22, 2018
@jorisvandenbossche jorisvandenbossche added this to the 0.24.0 milestone Jul 22, 2018
@jorisvandenbossche jorisvandenbossche added the Code Style Code style, linting, code_checks label Jul 22, 2018
@jorisvandenbossche jorisvandenbossche merged commit 0828c25 into pandas-dev:master Jul 22, 2018
@jorisvandenbossche
Copy link
Member

@holymonson Thanks!

holymonson added a commit to holymonson/pandas that referenced this pull request Jul 23, 2018
Sup3rGeo pushed a commit to Sup3rGeo/pandas that referenced this pull request Oct 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Style Code style, linting, code_checks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants