CLN: Remove Unneeded BlockManager methods #22002
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #22002 +/- ##
==========================================
- Coverage 92% 91.99% -0.01%
==========================================
Files 170 170
Lines 50609 50594 -15
==========================================
- Hits 46561 46546 -15
Misses 4048 4048
Continue to review full report at Codecov.
|
gfyoung
added
Internals
jorisvandenbossche
changed the title
jorisvandenbossche
approved these changes
Jul 26, 2018
|
thanks, always +1 on removing code! |
Sup3rGeo
pushed a commit
to Sup3rGeo/pandas
that referenced
this pull request
Oct 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BlockManager.get_scalar is never used outside of tests,
BlockManager._is_indexed_like is only ever called from
merge, which is only called once in Panel, before which the indexed_like check is already done.Also BlockPlacements.iadd was more complicated than it needed to be, so tore out bits of that.