Skip to content

TST: tuple and namedtuple multiindex tests for read_csv #21994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 25, 2018

Conversation

dahlbaek
Copy link
Contributor

@dahlbaek
Copy link
Contributor Author

dahlbaek commented Jul 20, 2018

#21995 should probably be resolved before this is considered for merging.

@codecov
Copy link

codecov bot commented Jul 20, 2018

Codecov Report

Merging #21994 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #21994   +/-   ##
=======================================
  Coverage   91.96%   91.96%           
=======================================
  Files         166      166           
  Lines       50334    50334           
=======================================
  Hits        46292    46292           
  Misses       4042     4042
Flag Coverage Δ
#multiple 90.36% <ø> (ø) ⬆️
#single 42.22% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f6ddc4...4aea4ed. Read the comment docs.

@gfyoung gfyoung added Testing pandas testing functions or related to the test suite Dtype Conversions Unexpected or buggy dtype conversions MultiIndex labels Jul 22, 2018
@jreback
Copy link
Contributor

jreback commented Jul 24, 2018

#21995 should probably be resolved before this is considered for merging.

is orthogonal no?

@jreback jreback added this to the 0.24.0 milestone Jul 24, 2018
@dahlbaek
Copy link
Contributor Author

@jreback wrote:

is orthogonal no?

Possibly you're right. In any case, I think this PR does what it is supposed to, and #21995 seems likely to be resolved by extending the to_csv/read_csv docs rather than changing any behaviour. Please let me know if you think I missed something obvious in this PR.

@jreback
Copy link
Contributor

jreback commented Jul 25, 2018

@dahlbaek as I said that #21995 is orthogonal.

thanks

@jreback jreback merged commit a6c7387 into pandas-dev:master Jul 25, 2018
@dahlbaek dahlbaek deleted the tests/multiindex branch July 25, 2018 18:50
Sup3rGeo pushed a commit to Sup3rGeo/pandas that referenced this pull request Oct 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dtype Conversions Unexpected or buggy dtype conversions MultiIndex Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

read_csv in Pandas 0.14 loads NaNs when namedtuple is used for column names
3 participants