Skip to content

CLN: Remove unused variables #21986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jul 29, 2018
Merged

CLN: Remove unused variables #21986

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
966d79a
CLN: Remove unused variables
Jul 20, 2018
a154bf5
Add back variable that was a check
Jul 20, 2018
b908aff
Remove unnecessary vars and test
Jul 20, 2018
234984a
add memo docstring
Jul 20, 2018
82683e5
Merge remote-tracking branch 'upstream/master' into remove_variables
Jul 24, 2018
d5ddbc1
Misspelled Validate
Jul 24, 2018
0d7f077
Add test for modified behavior
Jul 26, 2018
8492e93
Use np.int64 for windows
Jul 26, 2018
8a4f531
Merge remote-tracking branch 'upstream/master' into remove_variables
Jul 27, 2018
05e4a36
Merge remote-tracking branch 'upstream/master' into remove_variables
Jul 28, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions pandas/core/nanops.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -479,6 +479,9 @@ def nanvar(values, axis=None, skipna=True, ddof=1):

@disallow('M8', 'm8')
def nansem(values, axis=None, skipna=True, ddof=1):
# This checks if non-numeric-like data is passed with numeric_only=False
# and raises a TypeError otherwise
var = nanvar(values, axis, skipna, ddof=ddof)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If var isn't used, don't assign the result of nanvar to a variable. Just call it without.


mask = isna(values)
if not is_float_dtype(values.dtype):
Expand Down