Add option for alternative correlation types to DataFrame.corrwith()
#21941
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gfyoung
reviewed
Jul 17, 2018
| @@ -6891,7 +6891,7 @@ def cov(self, min_periods=None): | |||
|
|
|||
| return self._constructor(baseCov, index=idx, columns=cols) | |||
|
|
|||
| def corrwith(self, other, axis=0, drop=False): | |||
| def corrwith(self, other, axis=0, method='pearson', drop=False): | |||
There was a problem hiding this comment.
Hmm...it would be safest to add it to the end of the signature, as this modification as it stands is not backwards compatible. Alternatively, you could issue a DeprecationWarning if a boolean is passed to method and re-assign it to drop.
Could you demonstrate this speed improvement with the ASV? I am a little dubious that the iterative method is more performant than the existing implementation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master -u -- "*.py" | flake8 --diffThis adds a
methodargument toDataFrame.corrwith()which calls the corresponding correlation function which already exists within pandas. The default option "pearson" was originally implemented directly in this method, I changed it to match the other options for consistency (and a slight speed improvement).