-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
Use the Agg backend for docs builds #21914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This uses a non-interactive Agg matplotlib backend to build docs, which avoids trying to use the default MacOS backend, which can fail in some environments. Closes pandas-dev#21913.
Codecov Report
@@ Coverage Diff @@
## master #21914 +/- ##
=======================================
Coverage 91.96% 91.96%
=======================================
Files 166 166
Lines 50323 50323
=======================================
Hits 46281 46281
Misses 4042 4042
Continue to review full report at Codecov.
|
Looks good, tested on Linux. I was just guessing whether it'd be possible to set an environment variable in I'd say this link is about the same problem: https://stackoverflow.com/questions/25124977/cant-use-sphinxs-matplotlib-extension-with-qt-on-os-x#25164523 What do you think @tdsmith ? |
Just to check, this has no influence on how the figures look in the docs? (the quality) |
I would also assume this can be set in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @tdsmith, lgtm.
Thanks for the review, all! I just realized you asked for conf.py and not make.py -- it works for me in either place; AFAICT tweaking the environment is still the right thing to do in either place. |
thanks @tdsmith |
* Use the Agg backend for docs builds This uses a non-interactive Agg matplotlib backend to build docs, which avoids trying to use the default MacOS backend, which can fail in some environments. Closes pandas-dev#21913. * Modify make.py instead of adding a matplotlibrc
* Use the Agg backend for docs builds This uses a non-interactive Agg matplotlib backend to build docs, which avoids trying to use the default MacOS backend, which can fail in some environments. Closes pandas-dev#21913. * Modify make.py instead of adding a matplotlibrc
This uses a non-interactive Agg matplotlib backend to build docs, which avoids trying to use the default MacOS backend, which can fail in some environments.
Closes #21913.