DOC: move feature to correct whatsnew section; typos #21897
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
requested changes
Jul 14, 2018
doc/source/whatsnew/v0.24.0.txt
Outdated
| @@ -70,6 +68,7 @@ Current Behavior: | |||
|
|
|||
| Other Enhancements | |||
| ^^^^^^^^^^^^^^^^^^ | |||
| - ``ExcelWriter`` now accepts ``mode`` as a keyword argument, enabling append to existing workbooks when using the ``openpyxl`` engine (:issue:`3441`) | |||
There was a problem hiding this comment.
leave this where it was. this is a significant new feature that's why i put it there.
jreback
reviewed
Jul 14, 2018
doc/source/whatsnew/v0.24.0.txt
Outdated
| @@ -8,15 +8,20 @@ v0.24.0 (Month XX, 2018) | |||
| New features | |||
| ~~~~~~~~~~~~ | |||
|
|
|||
| - ``ExcelWriter`` now accepts ``mode`` as a keyword argument, enabling append to existing workbooks when using the ``openpyxl`` engine (:issue:`3441`) | |||
| .. _whatsnew_0240.enhancements.excel_writer_mode: | |||
There was a problem hiding this comment.
just leave it like it was, its not necessary to make a sub-section, just a single entry is fine.
There was a problem hiding this comment.
Was just writing why I did that, but you were faster. Fair enough. Not much left of this PR then, but OK.
h-vetinari
force-pushed
the
whatsnew_fixes
branch
from
5479fe2 to
ad10e77
Compare
h-vetinari
force-pushed
the
whatsnew_fixes
branch
from
ad10e77 to
66a21b2
Compare
jreback
approved these changes
Jul 14, 2018
|
thanks! |
Sup3rGeo
pushed a commit
to Sup3rGeo/pandas
that referenced
this pull request
Oct 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splitting up #21645.
Motivation is easy: when I started working on #21645, there was nothing under "New Features" (usually having a descriptive section each) except this one-liner. To me, this belongs to "Other Enhancements".
Plus found some typos and stuff where the
rstbreaks (cannot have something directly after closing backticks).