Skip to content

use npy_datetimestruct instead of pandas_datetimestruct #21886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 14, 2018
Merged

use npy_datetimestruct instead of pandas_datetimestruct #21886

merged 1 commit into from
Jul 14, 2018

Conversation

jbrockmendel
Copy link
Member

Follow-on to #21863

@codecov
Copy link

codecov bot commented Jul 13, 2018 •
edited
Loading

Codecov Report

Merging #21886 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #21886   +/-   ##
=======================================
  Coverage   91.91%   91.91%           
=======================================
  Files         164      164           
  Lines       49992    49992           
=======================================
  Hits        45952    45952           
  Misses       4040     4040
Flag Coverage Δ
#multiple 90.3% <ø> (ø) ⬆️
#single 42.16% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bdb6168...31e756d. Read the comment docs.

@gfyoung gfyoung added Datetime Datetime data dtype Internals Related to non-user accessible pandas implementation Clean labels Jul 13, 2018
@jbrockmendel
Copy link
Member Author

@WillAyd thoughts? Should be easy follow-up to PANDAS_DATETIMEUNIT change

@jreback jreback added this to the 0.24.0 milestone Jul 14, 2018
@jreback jreback merged commit 56b2f0e into pandas-dev:master Jul 14, 2018
@jreback
Copy link
Contributor

jreback commented Jul 14, 2018

thanks @jbrockmendel

@jreback
Copy link
Contributor

jreback commented Jul 14, 2018 •
edited
Loading

when i rebuilt locally after merging this I got an error about finding pandas_datetimeunit, so I think we are missing a dep somewhere (on a np.datetime.pxd?)

works after a make clean

@jbrockmendel jbrockmendel deleted the dts branch July 14, 2018 15:38
@jbrockmendel jbrockmendel mentioned this pull request Jul 16, 2018
Closed
10 tasks
Sup3rGeo pushed a commit to Sup3rGeo/pandas that referenced this pull request Oct 1, 2018
@jbrockmendel
use npy_datetimestruct (pandas-dev#21886)
48279bf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Clean Datetime Datetime data dtype Internals Related to non-user accessible pandas implementation
Projects
None yet
Milestone
0.24.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jbrockmendel @jreback @gfyoung