BUG: Align Series.str.zfill() with str.zfill() #21874
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gfyoung
changed the title
gfyoung
reviewed
Jul 12, 2018
|
|
||
| if not is_integer(width): | ||
| msg = 'width must be of integer type, not {0}' | ||
| raise TypeError(msg.format(type(width).__name__)) |
There was a problem hiding this comment.
Add test for this validation.
|
@atulagrwl : Good start! Need a |
|
Added the validation test in last commit and added whatsnew entry too. |
jreback
requested changes
Jul 12, 2018
| @@ -2220,27 +2220,31 @@ def test_center_ljust_rjust_fillchar(self): | |||
| result = values.str.rjust(5, fillchar=1) | |||
|
|
|||
| def test_zfill(self): | |||
There was a problem hiding this comment.
the issue mentions also affecting rjust, pad, center, can you add / update tests as needed for those as well.
jreback
requested changes
Jul 12, 2018
| @@ -84,6 +84,7 @@ Other Enhancements | |||
| - :meth:`Series.nlargest`, :meth:`Series.nsmallest`, :meth:`DataFrame.nlargest`, and :meth:`DataFrame.nsmallest` now accept the value ``"all"`` for the ``keep`` argument. This keeps all ties for the nth largest/smallest value (:issue:`16818`) | |||
| - :class:`IntervalIndex` has gained the :meth:`~IntervalIndex.set_closed` method to change the existing ``closed`` value (:issue:`21670`) | |||
| - :func:`~DataFrame.to_csv` and :func:`~DataFrame.to_json` now support ``compression='infer'`` to infer compression based on filename (:issue:`15008`) | |||
| - :func:`Series.str.zfill()` now matches with standard string library zfill (:issue:`20868`) | |||
There was a problem hiding this comment.
see comments, make this a sub section in api breaking (yes its a bug fix, but an unexpected one)
There was a problem hiding this comment.
Also, parentheses not needed at the end of zfill in the :func: ref.
|
can you rebase |
|
closing as stale. if you'd like to continue, pls ping. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master -u -- "*.py" | flake8 --diffUsing standard library
zfillmethod directly to handle specific characters issue