TST: Parameterize more tests #21873
Merged
TST: Parameterize more tests #21873
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gfyoung
added
Testing
gfyoung
force-pushed
the
parametrize-more-tests
branch
from
78677ef to
b8fd10b
Compare
jreback
approved these changes
Jul 12, 2018
| @@ -21,6 +21,11 @@ | |||
| import pandas as pd | |||
|
|
|||
|
|
|||
| @pytest.fixture(params=[str, compat.text_type]) | |||
There was a problem hiding this comment.
may consider in the future to move this fixture to conftest (needs a good name though)
|
lgtm. merge on green. |
* frame/test_dtypes.py * series/indexing/test_boolean.py * reshape/merge/test_merge_asof.py
gfyoung
force-pushed
the
parametrize-more-tests
branch
from
b8fd10b to
d9a3315
Compare
Codecov Report
@@ Coverage Diff @@
## master #21873 +/- ##
==========================================
- Coverage 91.91% 91.91% -0.01%
==========================================
Files 164 164
Lines 49992 49992
==========================================
- Hits 45952 45951 -1
- Misses 4040 4041 +1
Continue to review full report at Codecov.
|
|
Finally green! Merging. |
Sup3rGeo
pushed a commit
to Sup3rGeo/pandas
that referenced
this pull request
Oct 1, 2018
* frame/test_dtypes.py * series/indexing/test_boolean.py * reshape/merge/test_merge_asof.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add parameterization to the following tests:
frame/test_dtypes.pyseries/indexing/test_boolean.pyreshape/merge/test_merge_asof.py