API: Add DataFrame.droplevel #21871

vbarda · 2018-07-12T01:50:50Z

closes API: Add DataFrame.droplevel #20342
tests added / passed
passes git diff upstream/master -u -- "*.py" | flake8 --diff
whatsnew entry

pep8speaks · 2018-07-12T01:50:57Z

Hello @vbarda! Thanks for updating the PR.

Cheers ! There are no PEP8 issues in this Pull Request. 🍻

Comment last updated on July 19, 2018 at 13:18 Hours UTC

datapythonista · 2018-07-12T03:39:17Z

Thanks for the contribution @vbarda.

From the issue, I'd say we want this method in index, not in DataFrame. @TomAugspurger can you please confirm?

Also, you're missing adding a comment to the whatsnew documentation (if you don't know how to do it, you can check closed PRs to see how it's done).

codecov · 2018-07-12T05:52:47Z

Codecov Report

Merging #21871 into master will increase coverage by 0.05%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master   #21871      +/-   ##
==========================================
+ Coverage   91.91%   91.96%   +0.05%     
==========================================
  Files         164      166       +2     
  Lines       49987    50334     +347     
==========================================
+ Hits        45947    46292     +345     
- Misses       4040     4042       +2

Flag	Coverage Δ
#multiple	`90.36% <100%> (+0.06%)`	⬆️
#single	`42.22% <20%> (+0.06%)`	⬆️

Impacted Files	Coverage Δ
pandas/core/generic.py	`96.47% <100%> (+0.01%)`	⬆️
pandas/core/indexes/timedeltas.py	`91.53% <0%> (-0.65%)`	⬇️
pandas/core/indexes/base.py	`96.35% <0%> (-0.23%)`	⬇️
pandas/core/indexes/datetimes.py	`95.16% <0%> (-0.18%)`	⬇️
pandas/core/algorithms.py	`94.69% <0%> (-0.16%)`	⬇️
pandas/io/packers.py	`88.04% <0%> (-0.16%)`	⬇️
pandas/core/reshape/merge.py	`94.1% <0%> (-0.16%)`	⬇️
pandas/core/common.py	`92.08% <0%> (-0.12%)`	⬇️
pandas/core/indexes/period.py	`93.17% <0%> (-0.04%)`	⬇️
pandas/core/dtypes/common.py	`95.07% <0%> (ø)`	⬆️
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d94a95...6b8f22b. Read the comment docs.

jreback

looks pretty good. can you add:

whatsnew note in 0.24.0, new features, with a reference to the method
add the method in api.rst
move to generic as indicated.

jreback · 2018-07-12T10:21:55Z

pandas/core/frame.py

+
+        axis : {0 or 'index', 1 or 'columns'}, default 0
+
+        .. versionadded:: 0.24.0


move the versionadded to right after the summary (2nd line of doc-string)

jreback · 2018-07-12T10:22:29Z

pandas/core/frame.py

@@ -4630,6 +4630,63 @@ def sortlevel(self, level=0, axis=0, ascending=True, inplace=False,
        return self.sort_index(level=level, axis=axis, ascending=ascending,
                               inplace=inplace, sort_remaining=sort_remaining)

+    def droplevel(self, level, axis=0):
+        """Return DataFrame with requested index / column level(s) removed.


can you move this to generic so Series gets this as well

jreback · 2018-07-12T10:22:41Z

pandas/core/frame.py

+        1 2      3   4
+        5 6      7   8
+        9 10    11  12
+        >>> df.droplevel('a')


blank line between cases

jreback · 2018-07-12T10:25:16Z

pandas/core/frame.py

+        """
+        result = self.copy()
+        axis = self._get_axis_number(axis)
+        if axis == 0:


this can be more generic (so works for series as well), eg.

can remove the .copy() (as set_axis copies)

labels = self._get_axis(axis) labels = labels.droplevel(level) result = self.set_axis(labels, axis=axis) return result

jreback · 2018-07-12T10:25:28Z

pandas/tests/frame/test_alter_axes.py

@@ -1056,6 +1056,30 @@ def test_reindex_signature(self):
                              "limit", "copy", "level", "method",
                              "fill_value", "tolerance"}

+    def test_droplevel(self):


add the issue number as a comment

jreback · 2018-07-12T10:27:10Z

@datapythonista

From the issue, I'd say we want this method in index, not in DataFrame. @TomAugspurger can you please confirm?

it already exists for Index, this is exposing on Series/DataFrame.

vbarda · 2018-07-12T20:51:43Z

Thank you for the comments -- addressing the changes now

jreback · 2018-07-14T15:07:33Z

doc/source/whatsnew/v0.24.0.txt

@@ -74,6 +74,7 @@ Other Enhancements
 - :func:`Series.mode` and :func:`DataFrame.mode` now support the ``dropna`` parameter which can be used to specify whether NaN/NaT values should be considered (:issue:`17534`)
 - :func:`to_csv` now supports ``compression`` keyword when a file handle is passed. (:issue:`21227`)
 - :meth:`Index.droplevel` is now implemented also for flat indexes, for compatibility with :class:`MultiIndex` (:issue:`21115`)
+- :meth:`Series.droplevel` and `DataFrame.droplevel` are now implemented


add the issue number here

jreback · 2018-07-14T15:07:53Z

pandas/core/generic.py

@@ -716,6 +716,62 @@ def swapaxes(self, axis1, axis2, copy=True):

        return self._constructor(new_values, *new_axes).__finalize__(self)

+    def droplevel(self, level, axis=0):
+        """Return DataFrame with requested index / column level(s) removed.
+        .. versionadded:: 0.24.0


I think you need a blank line here? @jorisvandenbossche

jreback · 2018-07-14T15:08:12Z

pandas/core/generic.py

+        ----------
+        level : int, str, or list-like
+            If a string is given, must be the name of a level
+            If list-like, elements must be names or indexes of levels.


indexes -> positional indexes

jreback · 2018-07-14T15:08:35Z

pandas/tests/frame/test_alter_axes.py

+    def test_droplevel(self):
+        # GH20342
+        df = pd.DataFrame([
+            [1, 2, 3, 4],


can you add tests for series as well

I did, on lines 1085-1089 :)

oh not in THIS test. pls separate out and put in tests/series/test_alter_axes

jreback · 2018-07-14T15:18:14Z

pandas/tests/frame/test_alter_axes.py

+    def test_droplevel(self):
+        # GH20342
+        df = pd.DataFrame([
+            [1, 2, 3, 4],


oh not in THIS test. pls separate out and put in tests/series/test_alter_axes

jreback · 2018-07-14T15:18:29Z

pandas/tests/frame/test_alter_axes.py

+                                               names=['level_1', 'level_2'])
+
+        # test that dropping of a level in DataFrame index works
+        expected_df_no_level_a_in_index = df.reset_index('a', drop=True)


dont' use these long names, expected and result are much easier to grok

jreback · 2018-07-14T15:19:05Z

pandas/tests/frame/test_alter_axes.py

+
+        # test that dropping of a level in Series index works
+        expected_ser_no_level_b_in_index = ser.reset_index('b', drop=True)
+        actual_ser_no_level_b_in_index = ser.droplevel('b')


when you move add a test that raises when axis !=0 is specified

jreback · 2018-07-14T15:19:32Z

pandas/tests/frame/test_alter_axes.py

+        assert_frame_equal(expected_df_no_level_a_in_index,
+                           actual_df_no_level_a_in_index)
+
+        # test that dropping of a level in DataFrame columns works


can you parameterize these on axis and also try with axis='columns', and axis='index'

jreback

@vbarda minor comments, but have a question about the API.

jreback · 2018-07-16T10:43:19Z

doc/source/whatsnew/v0.24.0.txt

@@ -74,6 +74,7 @@ Other Enhancements
 - :func:`Series.mode` and :func:`DataFrame.mode` now support the ``dropna`` parameter which can be used to specify whether NaN/NaT values should be considered (:issue:`17534`)
 - :func:`to_csv` now supports ``compression`` keyword when a file handle is passed. (:issue:`21227`)
 - :meth:`Index.droplevel` is now implemented also for flat indexes, for compatibility with :class:`MultiIndex` (:issue:`21115`)
+- :meth:`Series.droplevel` and `DataFrame.droplevel` are now implemented (:issue:`20342`)


need ref for DataFrame.droplevel

could you please explain more, not sure what you mean

You have

`DataFrame.droplevel`

Should be

:meth:`DataFrame.droplevel`

jreback · 2018-07-16T10:43:37Z

pandas/core/generic.py

+        ...:     [5, 6, 7, 8],
+        ...:     [9, 10, 11, 12]
+        ...: ]).set_index([0, 1]).rename_axis(['a', 'b'])
+        >>> df.columns = pd.MultiIndex.from_tuples([


can you add blank lines in between here

jreback · 2018-07-16T10:44:22Z

pandas/core/generic.py

@@ -716,6 +716,64 @@ def swapaxes(self, axis1, axis2, copy=True):

        return self._constructor(new_values, *new_axes).__finalize__(self)

+    def droplevel(self, level, axis=0):


anyone think we should add inplace to make this consistent, with other axis ops (e.g. reset_index / set_index)?

cc @TomAugspurger

makes sense to me to expose inplace!

I'd say leave it out for now, unless someone asks for it.

okay, will do!

jreback · 2018-07-20T13:11:41Z

thanks @vbarda nice patch!

can you create an issue about adding inplace to .droplevel.

vbarda · 2018-07-20T13:36:45Z

Thank you -- will add the issue now!

vbarda · 2018-07-20T13:45:46Z

Added here: #21990

vbarda added 2 commits July 12, 2018 01:43

API: Add DataFrame.droplevel

b46d46f

better docstring

8836d3f

pep-8

7862326

datapythonista added Indexing Related to indexing on series/frames, not to indexes themselves MultiIndex API Design labels Jul 12, 2018

jreback requested changes Jul 12, 2018

View reviewed changes

vbarda added 3 commits July 12, 2018 21:37

address comments

c43d261

add comment to the test

95336db

lint

5f9c648

jreback requested changes Jul 14, 2018

View reviewed changes

jreback added this to the 0.24.0 milestone Jul 14, 2018

address comments

808bc16

jreback requested changes Jul 14, 2018

View reviewed changes

vbarda added 2 commits July 14, 2018 15:34

move tests for series to a dedicated file

dbc25da

lint

2333f7c

jreback requested changes Jul 16, 2018

View reviewed changes

address minor comments

6b8f22b

jreback approved these changes Jul 20, 2018

View reviewed changes

jreback merged commit b9c1786 into pandas-dev:master Jul 20, 2018

vbarda deleted the add-droplevel branch July 20, 2018 15:14

Sup3rGeo pushed a commit to Sup3rGeo/pandas that referenced this pull request Oct 1, 2018

API: Add DataFrame.droplevel (pandas-dev#21871)

57c7ccf

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

API: Add DataFrame.droplevel #21871

API: Add DataFrame.droplevel #21871

vbarda commented Jul 12, 2018

pep8speaks commented Jul 12, 2018 •

edited

Loading

datapythonista commented Jul 12, 2018

codecov bot commented Jul 12, 2018 •

edited

Loading

jreback left a comment

jreback Jul 12, 2018

jreback Jul 12, 2018

jreback Jul 12, 2018

jreback Jul 12, 2018

jreback Jul 12, 2018

jreback commented Jul 12, 2018

vbarda commented Jul 12, 2018

jreback Jul 14, 2018

jreback Jul 14, 2018

jreback Jul 14, 2018

jreback Jul 14, 2018

vbarda Jul 14, 2018

jreback Jul 14, 2018

jreback Jul 14, 2018

jreback Jul 14, 2018

jreback Jul 14, 2018

jreback Jul 14, 2018

jreback left a comment

jreback Jul 16, 2018

vbarda Jul 16, 2018

TomAugspurger Jul 19, 2018

vbarda Jul 19, 2018

jreback Jul 16, 2018

jreback Jul 16, 2018

vbarda Jul 16, 2018

TomAugspurger Jul 19, 2018

vbarda Jul 19, 2018

jreback commented Jul 20, 2018

vbarda commented Jul 20, 2018

vbarda commented Jul 20, 2018


		axis : {0 or 'index', 1 or 'columns'}, default 0

		.. versionadded:: 0.24.0

		@@ -716,6 +716,64 @@ def swapaxes(self, axis1, axis2, copy=True):

		return self._constructor(new_values, *new_axes).__finalize__(self)

		def droplevel(self, level, axis=0):

API: Add DataFrame.droplevel #21871

API: Add DataFrame.droplevel #21871

Conversation

vbarda commented Jul 12, 2018

pep8speaks commented Jul 12, 2018 • edited Loading

Comment last updated on July 19, 2018 at 13:18 Hours UTC

datapythonista commented Jul 12, 2018

codecov bot commented Jul 12, 2018 • edited Loading

Codecov Report

jreback left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jreback commented Jul 12, 2018

vbarda commented Jul 12, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jreback left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jreback commented Jul 20, 2018

vbarda commented Jul 20, 2018

vbarda commented Jul 20, 2018

pep8speaks commented Jul 12, 2018 •

edited

Loading

codecov bot commented Jul 12, 2018 •

edited

Loading