[CLN] De-privatize commonly-used functions #21870
Conversation
gfyoung
added
Internals
|
looks ok, something failing. |
|
Messed up whitespace in rebasing, should be fixed now. |
Codecov Report
@@ Coverage Diff @@
## master #21870 +/- ##
==========================================
+ Coverage 91.96% 91.96% +<.01%
==========================================
Files 166 166
Lines 50323 50329 +6
==========================================
+ Hits 46281 46287 +6
Misses 4042 4042
Continue to review full report at Codecov.
|
|
CI failure was a ResourceWarning. Had to edit something to re-push, so de-privatized _ensure_categorical. |
|
ping. I'd like to get this out of the way before inevitable merge conflicts arise. |
|
ahh i merged in a funny order, can you rebase |
|
Done |
pandas/core/common.py
Outdated
| @@ -120,7 +120,7 @@ def is_bool_indexer(key): | |||
| return False | |||
|
|
|||
|
|
|||
| def _default_index(n): | |||
| def default_index(n): | |||
There was a problem hiding this comment.
this entire module, is technically public, though we have a mix of public/private here anyway, so have to be careful about changing public functions here (obviously this is private -> public).
There was a problem hiding this comment.
let' move this to pandas.index.base , ok to call it default_index
|
thanks @jbrockmendel ! |
Also updated numpy_helper to not use things from numpy's deprecated C API. This won't get rid of the warnings since cython still causes them, but it's still nice.
Not sure how to lint for this (or if we really want to), will see if google knows.