[CLN] cy cleanup, de-duplication

[jbrockmendel]

Small cleanups, remove some unnecessary casting, add typing in timezones.

[jreback]

looks fine. may want to run a perf check as touching some sensitive paths.

[jbrockmendel]

Traveling today, will run asv when home. It should be a clear but very small improvement.

…

On Mon, Jul 9, 2018 at 7:52 AM Jeff Reback ***@***.***> wrote: looks fine. may want to run a perf check as touching some sensitive paths. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#21826 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AHtGeKQPUh8dHkqNsKzOa0T71CV1h4AIks5uE1IPgaJpZM4VHkva> .

[codecov]

Codecov Report

Merging #21826 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #21826   +/-   ##
=======================================
  Coverage    91.9%    91.9%           
=======================================
  Files         160      160           
  Lines       49892    49892           
=======================================
  Hits        45852    45852           
  Misses       4040     4040

Flag	Coverage Δ
#multiple	90.28% <ø> (ø)	⬆️
#single	42.1% <ø> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5380fcd...13c4e8a. Read the comment docs.

[jbrockmendel]

asv is raising git-related errors for me on both linux and mac. Is anyone else getting these?
update caused by me messing up the cloning, never mind.

[jbrockmendel]

Results are probably meaningless, but at least they're all good-meaningless.

asv continuous -E virtualenv -f 1.1 master HEAD -b timeseries
[...]
    before     after       ratio
  [da6e26db] [13c4e8a0]
-    8.39ms     7.61ms      0.91  timeseries.ToDatetimeISO8601.time_iso8601_nosep
-    2.36ms     2.11ms      0.89  timeseries.ResampleSeries.time_resample('datetime', '1D', 'ohlc')
-    6.98μs     6.21μs      0.89  timeseries.DatetimeIndex.time_get('tz_aware')
-    5.91μs     5.01μs      0.85  timeseries.DatetimeIndex.time_get('tz_naive')

[jreback]

thanks !