move PeriodIndex comparisons, implement PeriodArray constructor #21798
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
requested changes
Jul 7, 2018
| @@ -33,6 +35,47 @@ def f(self): | |||
| return property(f) | |||
|
|
|||
|
|
|||
| def _period_array_cmp(opname, cls): | |||
| """ | |||
There was a problem hiding this comment.
in the future can you add some comments / doc-string here
| @@ -161,3 +300,16 @@ def _maybe_convert_timedelta(self, other): | |||
| msg = "Input has different freq from {cls}(freq={freqstr})" | |||
| raise IncompatibleFrequency(msg.format(cls=type(self).__name__, | |||
| freqstr=self.freqstr)) | |||
|
|
|||
| @classmethod | |||
There was a problem hiding this comment.
should this use ExtensionOpsMixin ?
jreback
added
Period
jreback
approved these changes
Jul 7, 2018
|
thanks @jbrockmendel |
Sup3rGeo
pushed a commit
to Sup3rGeo/pandas
that referenced
this pull request
Oct 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PeriodIndex comparisons turn out to be easier to move than the others (though partly because ATM they are broken: #21793), so this moves them over first.
Following that, most of the remaining PeriodArray arithmetic methods require
shift, which in turns requires the constructors, so I went ahead and implemented those in PeriodArrayMixin. Still holding off on TimedeltaArray and DatetimeArray constructors.Found a few more things that could be harmlessly moved and some docstring fixups.
CC: @jorisvandenbossche @TomAugspurger @jreback