-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
DOC: remove imports and use pd in docstrings #21797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: remove imports and use pd in docstrings #21797
Conversation
git diff upstream/master -u -- "*.py" | flake8 --diff
- [ ] whatsnew entry
looks like this is not rebase on master can you do
|
@jreback .. ok.. will do! |
pandas/core/indexes/multi.py
Outdated
@@ -345,7 +345,7 @@ def set_levels(self, levels, level=None, inplace=False, | |||
|
|||
Examples | |||
-------- | |||
>>> idx = MultiIndex.from_tuples([(1, u'one'), (1, u'two'), | |||
>>> idx = pd.MultiIndex.from_tuples([(1, u'one'), (1, u'two'), | |||
(2, u'one'), (2, u'two')], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so can you adjust formatting to line things up (in theory this would fail the doc-string tests if we were running them). do this generally in this PR (e.g. wheverever you are changing things)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah.. modifying them.. now..
Codecov Report
@@ Coverage Diff @@
## master #21797 +/- ##
=========================================
Coverage ? 91.95%
=========================================
Files ? 160
Lines ? 49858
Branches ? 0
=========================================
Hits ? 45845
Misses ? 4013
Partials ? 0
Continue to review full report at Codecov.
|
@jorisvandenbossche look ok? |
@jreback .. I modified the files.. but noticed you already approved the changes.. do you want me to modify the PR or leave it as is? |
@alphaCTzo7G is ok for now. |
Heres the patch in case you want to apply it in this or in a different PR: https://github.com/alphaCTzo7G/pandas/commit/c27b5f45ee4be493bb76995d319a073026f6acf5 |
Can you add that commit here to this PR? (pushing to the branch should do that) |
Done... |
@alphaCTzo7G Thanks a lot ! |
No description provided.