Skip to content

DOC: remove imports and use pd in docstrings #21797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 8, 2018
Merged

DOC: remove imports and use pd in docstrings #21797

merged 7 commits into from
Jul 8, 2018

Conversation

alphaCTzo7G
Copy link
Contributor

No description provided.

@jreback jreback changed the title - [ ] closes #xxxx - [ ] tests added / passed - [ ] passes git diff upstream/master -u -- "*.py" | flake8 --diff - [ ] whatsnew entry DOC: remove imports Jul 7, 2018
@jreback
Copy link
Contributor

jreback commented Jul 7, 2018

looks like this is not rebase on master

can you do

git merge master

@alphaCTzo7G
Copy link
Contributor Author

@jreback .. ok.. will do!

@jreback jreback added the Docs label Jul 7, 2018
@@ -345,7 +345,7 @@ def set_levels(self, levels, level=None, inplace=False,

Examples
--------
>>> idx = MultiIndex.from_tuples([(1, u'one'), (1, u'two'),
>>> idx = pd.MultiIndex.from_tuples([(1, u'one'), (1, u'two'),
(2, u'one'), (2, u'two')],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so can you adjust formatting to line things up (in theory this would fail the doc-string tests if we were running them). do this generally in this PR (e.g. wheverever you are changing things)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah.. modifying them.. now..

@jreback jreback added this to the 0.24.0 milestone Jul 7, 2018
@codecov
Copy link

codecov bot commented Jul 7, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@9e1f6fd). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #21797   +/-   ##
=========================================
  Coverage          ?   91.95%           
=========================================
  Files             ?      160           
  Lines             ?    49858           
  Branches          ?        0           
=========================================
  Hits              ?    45845           
  Misses            ?     4013           
  Partials          ?        0
Flag Coverage Δ
#multiple 90.33% <100%> (?)
#single 42.08% <100%> (?)
Impacted Files Coverage Δ
pandas/core/sparse/series.py 95.2% <ø> (ø)
pandas/plotting/_misc.py 38.98% <ø> (ø)
pandas/core/window.py 96.28% <ø> (ø)
pandas/io/pytables.py 92.48% <ø> (ø)
pandas/core/resample.py 96.07% <ø> (ø)
pandas/core/dtypes/dtypes.py 95.98% <ø> (ø)
pandas/core/strings.py 98.63% <ø> (ø)
pandas/core/arrays/categorical.py 95.93% <ø> (ø)
pandas/core/algorithms.py 94.85% <ø> (ø)
pandas/core/frame.py 97.19% <ø> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e1f6fd...376617d. Read the comment docs.

@jreback
Copy link
Contributor

jreback commented Jul 7, 2018

@jorisvandenbossche look ok?

@alphaCTzo7G
Copy link
Contributor Author

@jreback .. I modified the files.. but noticed you already approved the changes.. do you want me to modify the PR or leave it as is?

@jreback
Copy link
Contributor

jreback commented Jul 7, 2018

@alphaCTzo7G is ok for now.

@alphaCTzo7G
Copy link
Contributor Author

Heres the patch in case you want to apply it in this or in a different PR: https://github.com/alphaCTzo7G/pandas/commit/c27b5f45ee4be493bb76995d319a073026f6acf5

@jorisvandenbossche
Copy link
Member

Heres the patch in case you want to apply it in this or in a different PR: alphaCTzo7G/pandas@c27b5f4

Can you add that commit here to this PR? (pushing to the branch should do that)

@alphaCTzo7G
Copy link
Contributor Author

Done...

@jorisvandenbossche jorisvandenbossche changed the title DOC: remove imports DOC: remove imports and use pd in docstrings Jul 8, 2018
@jorisvandenbossche jorisvandenbossche merged commit ec07ea8 into pandas-dev:master Jul 8, 2018
@jorisvandenbossche
Copy link
Member

@alphaCTzo7G Thanks a lot !

Sup3rGeo pushed a commit to Sup3rGeo/pandas that referenced this pull request Oct 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants