Skip to content

Move methods and properties to EA Mixin classes #21776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 6, 2018

Conversation

jbrockmendel
Copy link
Member

Not the all-at-once that @jorisvandenbossche asked for, but it's a much bigger chunk than the last few.

@jbrockmendel
Copy link
Member Author

TODO: docstrings will need to be updated, still say FooIndex

Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. minor comments for followup.

dtype: bool
""")

def to_julian_date(self):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

todo update doc-string

@jreback
Copy link
Contributor

jreback commented Jul 6, 2018

@TomAugspurger @jorisvandenbossche if any comments.

@jreback jreback added Datetime Datetime data dtype ExtensionArray Extending pandas with custom dtypes or arrays. labels Jul 6, 2018
@jreback jreback added this to the 0.24.0 milestone Jul 6, 2018
@jreback jreback merged commit 30eb48c into pandas-dev:master Jul 6, 2018
@jreback
Copy link
Contributor

jreback commented Jul 6, 2018

thank you sir!

@jbrockmendel jbrockmendel deleted the dtarrays21 branch July 6, 2018 18:56
Sup3rGeo pushed a commit to Sup3rGeo/pandas that referenced this pull request Oct 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Datetime Datetime data dtype ExtensionArray Extending pandas with custom dtypes or arrays.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants