Removed Need for OHLC As First Element if Used in .agg #21769
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillAyd
commented
Jul 6, 2018
| # let higher level handle | ||
| if _level: | ||
| return results | ||
| return list(compat.itervalues(results))[0] |
There was a problem hiding this comment.
There was no test coverage for this line and I can't feasibly think how this would be useful, hence the deletion
jreback
requested changes
Jul 6, 2018
pandas/tests/groupby/test_groupby.py
Outdated
|
|
||
|
|
||
| def test_groupby_agg_ohlc_non_first(): | ||
| df = pd.DataFrame([[1], [1]], columns=['foo'], |
There was a problem hiding this comment.
can you add the issue number as a comment
jreback
approved these changes
Jul 6, 2018
|
lgtm. merge on green. |
|
CircleCI failure was a resource warning unrelated to PR |
jreback
pushed a commit
that referenced
this pull request
Jul 7, 2018
jreback
added a commit
that referenced
this pull request
Jul 7, 2018
Sup3rGeo
pushed a commit
to Sup3rGeo/pandas
that referenced
this pull request
Oct 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master -u -- "*.py" | flake8 --diff