TST: Remove check_exact from assert_almost_equal #21756
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you're checking for approximate equality, there shouldn't be a parameter that allows you to disable that functionality.
Codecov Report
@@ Coverage Diff @@
## master #21756 +/- ##
=======================================
Coverage 91.93% 91.93%
=======================================
Files 159 159
Lines 49733 49733
=======================================
Hits 45721 45721
Misses 4012 4012
Continue to review full report at Codecov.
|
Sup3rGeo
pushed a commit
to Sup3rGeo/pandas
that referenced
this pull request
Oct 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From a semantic point of view, if you're checking for approximate equality, there shouldn't be a parameter that allows you to disable the whole purpose of the function.