Implement tslibs.__init__, move easy bits of tslib #21738
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #21738 +/- ##
==========================================
+ Coverage 91.92% 91.92% +<.01%
==========================================
Files 158 159 +1
Lines 49705 49708 +3
==========================================
+ Hits 45693 45696 +3
Misses 4012 4012
Continue to review full report at Codecov.
|
jreback
reviewed
Jul 5, 2018
| # flake8: noqa | ||
|
|
||
| from .conversion import normalize_date, localize_pydatetime, tz_convert_single | ||
| from .nattype import NaT, iNaT |
There was a problem hiding this comment.
next PR should have a test that exercises what is in this API, name it test_api.py and check that the namespace is locked down)
jreback
reviewed
Jul 5, 2018
| @@ -1025,6 +1025,35 @@ cdef inline str _render_tstamp(int64_t val): | |||
| # ---------------------------------------------------------------------- | |||
| # Normalization | |||
|
|
|||
|
|
|||
| def normalize_date(object dt): | |||
| """ | |||
There was a problem hiding this comment.
we ought to fix these names (prob rename date_normalize) in future PR
jreback
approved these changes
Jul 5, 2018
|
|
||
| Returns | ||
| ------- | ||
| normalized : datetime.datetime or Timestamp |
Merged
jreback
pushed a commit
that referenced
this pull request
Jul 6, 2018
Sup3rGeo
pushed a commit
to Sup3rGeo/pandas
that referenced
this pull request
Oct 1, 2018
Sup3rGeo
pushed a commit
to Sup3rGeo/pandas
that referenced
this pull request
Oct 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Easy answers to where
tslib.ints_to_pytimedeltaandtslib.normalize_datebelong, so this moves those.Starts populating the
tslibs.__init__namespace; leaves updating imports for later.Cleans up a couple of unnecessary imports elsewhere.