Implement _tz_convert_tzlocal_utc for de-duplication #21727
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbrockmendel
commented
Jul 4, 2018
| @@ -1205,7 +1187,6 @@ def is_date_array_normalized(ndarray[int64_t] stamps, tz=None): | |||
| for i in range(n): | |||
| # Adjust datetime64 timestamp, recompute datetimestruct | |||
| pos = trans.searchsorted(stamps[i]) - 1 | |||
| inf = tz._transition_info[pos] | |||
There was a problem hiding this comment.
unrelated to the rest of the PR
Codecov Report
@@ Coverage Diff @@
## master #21727 +/- ##
=======================================
Coverage 91.92% 91.92%
=======================================
Files 158 158
Lines 49705 49705
=======================================
Hits 45693 45693
Misses 4012 4012
Continue to review full report at Codecov.
|
jreback
requested changes
Jul 4, 2018
| @@ -608,32 +608,33 @@ cpdef inline datetime localize_pydatetime(datetime dt, object tz): | |||
| # ---------------------------------------------------------------------- | |||
| # Timezone Conversion | |||
|
|
|||
| cdef inline int64_t tz_convert_tzlocal_to_utc(int64_t val, tzinfo tz): | |||
| cdef inline int64_t _tz_convert_tzlocal_utc(int64_t val, tzinfo tz, | |||
| bint to_utc=True): | |||
There was a problem hiding this comment.
looks good. can you add what this function does in doc-string. and mark as this is private.
There was a problem hiding this comment.
Mind if I put the docsting in the follow-up? There’s a couple more coming up in the next few hours.
|
Yes, the private function is just for this module. |
jreback
approved these changes
Jul 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bunch of code in conversion (and a bit in resolution, period, and tslib) that can be de-duplicated. This is one part of ~5 steps in that process.