Skip to content

CLN: Delay converting bins to datetimelike until necessary #21724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

mroeschke
Copy link
Member

  • tests added / passed
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff

xref #20956, q/cut now returns datetimelike bins when retbins=True. Instead of always trying to convert bins to datetimelike (even when retbins=False), moving the conversion to _postprocess_for_cut until after retbins=True is checked

cc @jreback

@mroeschke mroeschke changed the title CLN: Delay converting bins to datelike until necessary CLN: Delay converting bins to datetimelike until necessary Jul 4, 2018
@codecov
Copy link

codecov bot commented Jul 4, 2018

Codecov Report

Merging #21724 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #21724   +/-   ##
=======================================
  Coverage   91.92%   91.92%           
=======================================
  Files         158      158           
  Lines       49702    49702           
=======================================
  Hits        45690    45690           
  Misses       4012     4012
Flag Coverage Δ
#multiple 90.3% <100%> (ø) ⬆️
#single 42% <0%> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/reshape/tile.py 94.73% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b13605...c9ea5b5. Read the comment docs.

@jreback jreback added Datetime Datetime data dtype Clean labels Jul 4, 2018
@jreback jreback added this to the 0.24.0 milestone Jul 4, 2018
@jreback jreback merged commit 7bb010c into pandas-dev:master Jul 4, 2018
@jreback
Copy link
Contributor

jreback commented Jul 4, 2018

thanks!

@mroeschke mroeschke deleted the cut_datetimelike_bins_followup branch July 4, 2018 16:04
Sup3rGeo pushed a commit to Sup3rGeo/pandas that referenced this pull request Oct 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Clean Datetime Datetime data dtype
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants