move ndarray-returning functions to EA mixin classes #21722
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @jbrockmendel! Thanks for updating the PR. Cheers ! There are no PEP8 issues in this Pull Request. 🍻 Comment last updated on July 04, 2018 at 17:06 Hours UTC |
Codecov Report
@@ Coverage Diff @@
## master #21722 +/- ##
==========================================
+ Coverage 91.92% 91.93% +<.01%
==========================================
Files 158 158
Lines 49702 49716 +14
==========================================
+ Hits 45690 45704 +14
Misses 4012 4012
Continue to review full report at Codecov.
|
jreback
requested changes
Jul 4, 2018
pandas/core/arrays/period.py
Outdated
| # ------------------------------------------------------------------ | ||
| # Arithmetic Methods | ||
|
|
||
| def _sub_datelike(self, other): | ||
| assert other is not NaT | ||
| return NotImplemented | ||
|
|
||
| def _maybe_convert_timedelta(self, other): | ||
| if isinstance( |
There was a problem hiding this comment.
can you add a doc-string to this one as it accepts many types
jreback
added
ExtensionArray
jreback
approved these changes
Jul 4, 2018
|
lgtm. ping on green. |
|
ping |
|
thanks! |
Sup3rGeo
pushed a commit
to Sup3rGeo/pandas
that referenced
this pull request
Oct 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Orthogonal to other EAMixin PRs.
The methods this moves are unchanged. Docstrings changed e.g. "DatetimeIndex" to "Datetime Array/Index". I'm open to suggestions for better wording.
The error message in
PeriodArrayMixin._maybe_convert_timedeltais changed to usetype(self).__name__instead of hardcodingPeriodIndex. Ditto the warning issued byPeriodArrayMixin.freq.setter.