Skip to content

ENH: Add set_closed method to IntervalIndex #21711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 3, 2018

Conversation

jschendel
Copy link
Member

@jschendel jschendel added this to the 0.24.0 milestone Jul 3, 2018
@codecov
Copy link

codecov bot commented Jul 3, 2018

Codecov Report

Merging #21711 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #21711      +/-   ##
==========================================
+ Coverage    91.9%   91.91%   +<.01%     
==========================================
  Files         158      158              
  Lines       49690    49695       +5     
==========================================
+ Hits        45670    45675       +5     
  Misses       4020     4020
Flag Coverage Δ
#multiple 90.28% <100%> (ø) ⬆️
#single 41.95% <20%> (-0.01%) ⬇️
Impacted Files Coverage Δ
pandas/core/indexes/interval.py 93.18% <100%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cd2679...9428144. Read the comment docs.

@jreback
Copy link
Contributor

jreback commented Jul 3, 2018

lgtm. @jorisvandenbossche @TomAugspurger

@jschendel
Copy link
Member Author

FYI - I'll refrain from doing any additional IntervalIndex updates after this, so as not to cause conflicts with any IntervalArray work (I'm assuming that @TomAugspurger or I will be working on that at some point during the sprint).

@TomAugspurger TomAugspurger merged commit 8f32214 into pandas-dev:master Jul 3, 2018
@TomAugspurger
Copy link
Contributor

Sounds good.

Would be nice to knock out IntervalArray during the sprint.

@jschendel jschendel deleted the ii-set-closed branch September 24, 2018 17:22
Sup3rGeo pushed a commit to Sup3rGeo/pandas that referenced this pull request Oct 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ENH: Add set_closed method to IntervalIndex
3 participants