remove unused cimport, parametrize test #21710
Conversation
| @@ -16,8 +16,6 @@ cimport numpy as cnp | |||
| from numpy cimport ndarray, uint8_t | |||
| cnp.import_array() | |||
|
|
|||
| cimport util | |||
There was a problem hiding this comment.
do you have a linter that catches this?
There was a problem hiding this comment.
We've discussed this a couple times and haven't found a good solution for this. It's on my list to bring up with the group at the sprint.
There was a problem hiding this comment.
right, just asking if you found a soln!
| def f(self): | ||
| sparse_op = getattr(splib, 'sparse_%s_float64' % op) | ||
| python_op = getattr(operator, op) | ||
| @pytest.mark.parametrize('opname', |
There was a problem hiding this comment.
worth making a fixture in conftest?
There was a problem hiding this comment.
I think this is a pretty specific set of strings that wouldn't get used often. But I didn't look at this closely, just saw that the existing formatting was crying out to be updated.
Codecov Report
@@ Coverage Diff @@
## master #21710 +/- ##
=========================================
Coverage ? 91.9%
=========================================
Files ? 158
Lines ? 49690
Branches ? 0
=========================================
Hits ? 45670
Misses ? 4020
Partials ? 0
Continue to review full report at Codecov.
|
|
thanks @jbrockmendel |
No description provided.