BUG : Adding *kwargs for name retention in Index args #21703
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @uds5501! Thanks for updating the PR.
Comment last updated on July 09, 2018 at 12:12 Hours UTC |
mroeschke
requested changes
Jul 2, 2018
|
@mroeschke Sure sir, would do |
uds5501
changed the title
|
@mroeschke I had a quick question. I made a commit regarding the whatsnew note in another path. If I want to add the commit in this PR itself.. how do I do that? |
|
@uds5501 I am not sure if I completely follow but you could potentially merge the other branch into this branch locally or just re-do the whatsnew entry. The latter is probably easiest since we are just talking about a one-liner |
mroeschke
reviewed
Jul 9, 2018
| @@ -526,6 +526,119 @@ def to_datetime(arg, errors='raise', dayfirst=False, yearfirst=False, | |||
| pandas.DataFrame.astype : Cast argument to a specified dtype. | |||
| pandas.to_timedelta : Convert argument to timedelta. | |||
| """ | |||
| from pandas.core.indexes.datetimes import DatetimeIndex | |||
There was a problem hiding this comment.
This block below already exists in _convert_listlike_datetimes
|
closing as dupe of #21848 which is farther along |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master -u -- "*.py" | flake8 --diff