move and de-privatize _localize_pydatetime, move shift_day to liboffsets #21691
Conversation
Codecov Report
@@ Coverage Diff @@
## master #21691 +/- ##
==========================================
- Coverage 91.9% 91.9% -0.01%
==========================================
Files 154 154
Lines 49659 49652 -7
==========================================
- Hits 45640 45633 -7
Misses 4019 4019
Continue to review full report at Codecov.
|
pandas/_libs/tslib.pyx
Outdated
| @@ -54,6 +54,7 @@ from tslibs.nattype cimport checknull_with_nat, NPY_NAT | |||
| from tslibs.timestamps cimport (create_timestamp_from_ts, | |||
| _NS_UPPER_BOUND, _NS_LOWER_BOUND) | |||
| from tslibs.timestamps import Timestamp | |||
| from tslibs.offsets import localize_pydatetime # noqa:F841 | |||
There was a problem hiding this comment.
would be ok with not doing this import and changing the tests
There was a problem hiding this comment.
After the current set of PRs I'm going to pitch an idea to 1) finish off tslib and 2) expose selected functions/classes in tslibs.__init__. I'd rather avoid futzing with imports until then.
There was a problem hiding this comment.
ok that's fine, though in this case its simple enough to remove, so should just do it, 1 less thing to do later
pandas/_libs/tslibs/offsets.pyx
Outdated
| @@ -494,6 +498,58 @@ class BaseOffset(_BaseOffset): | |||
| # ---------------------------------------------------------------------- | |||
| # RelativeDelta Arithmetic | |||
|
|
|||
| cpdef inline datetime localize_pydatetime(datetime dt, object tz): | |||
| """ | |||
| Take a datetime/Timestamp in UTC and localizes to timezone tz. | |||
There was a problem hiding this comment.
should this be in timezones.pyx?
There was a problem hiding this comment.
I'd prefer to keeping timezones "naive" of datetime/Timestamp implementations. It would be a decent fit with conversion though
pandas/_libs/tslibs/offsets.pyx
Outdated
| @@ -494,6 +498,58 @@ class BaseOffset(_BaseOffset): | |||
| # ---------------------------------------------------------------------- | |||
| # RelativeDelta Arithmetic | |||
|
|
|||
| cpdef inline datetime localize_pydatetime(datetime dt, object tz): | |||
| """ | |||
| Take a datetime/Timestamp in UTC and localizes to timezone tz. | |||
|
thanks @jbrockmendel |
The only non-test place where tslib._localize_pydatetime is used is in tseries.offsets. This moves that func to liboffsets, de-privatizes it, and moves tseris.offsets.shift_day up to liboffsets.
To avoid import proliferation this keeps localize_pydatetime in the tslib namespace so the tests can get at it.
Adds some typing to localize_pydatetime and fleshes out the docstring.