Skip to content

Misc cleanups, test parametrization #21690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 2, 2018
Merged

Conversation

jbrockmendel
Copy link
Member

No coherent theme: remove an unused variable in inference.pyx, make some imports more direct, parametrize a big test, and move a tslib-specific test to test_tslibs

@pep8speaks
Copy link

pep8speaks commented Jul 1, 2018

Hello @jbrockmendel! Thanks for updating the PR.

Cheers ! There are no PEP8 issues in this Pull Request. 🍻

Comment last updated on July 01, 2018 at 02:49 Hours UTC

@codecov
Copy link

codecov bot commented Jul 1, 2018

Codecov Report

Merging #21690 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #21690   +/-   ##
=======================================
  Coverage    91.9%    91.9%           
=======================================
  Files         154      154           
  Lines       49657    49657           
=======================================
  Hits        45638    45638           
  Misses       4019     4019
Flag Coverage Δ
#multiple 90.28% <ø> (ø) ⬆️
#single 41.9% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc45fba...2e4a2cd. Read the comment docs.

@jreback jreback added Testing pandas testing functions or related to the test suite Datetime Datetime data dtype labels Jul 2, 2018
@jreback jreback added this to the 0.24.0 milestone Jul 2, 2018
@jreback jreback merged commit 93c11c2 into pandas-dev:master Jul 2, 2018
@jreback
Copy link
Contributor

jreback commented Jul 2, 2018

thanks!

@jbrockmendel jbrockmendel deleted the tstests branch July 2, 2018 23:37
Sup3rGeo pushed a commit to Sup3rGeo/pandas that referenced this pull request Oct 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Datetime Datetime data dtype Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants