-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
BUG: Fix MI repr with long names #21655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jorisvandenbossche
merged 6 commits into
pandas-dev:master
from
TomAugspurger:repr-mi-tostring
Jul 2, 2018
Merged
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
6f2aca6
BUG: quickfix MI repr
TomAugspurger 8151293
Better fallback
TomAugspurger 4e11634
Py2 compat
TomAugspurger cebb741
Merge remote-tracking branch 'upstream/master' into repr-mi-tostring
TomAugspurger 2878358
update
TomAugspurger 4391c24
Merge branch 'master' into repr-mi-tostring
jorisvandenbossche File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -305,6 +305,44 @@ def test_repr_non_interactive(self): | |
assert not has_truncated_repr(df) | ||
assert not has_expanded_repr(df) | ||
|
||
def test_repr_truncates_terminal_size(self): | ||
# https://github.com/pandas-dev/pandas/issues/21180 | ||
# TODO: use mock fixutre. | ||
# This is being backported, so doing it directly here. | ||
try: | ||
from unittest import mock | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. should PR in 0.24.0 (to move this to test_decorators) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
except ImportError: | ||
mock = pytest.importorskip("mock") | ||
|
||
terminal_size = (118, 96) | ||
p1 = mock.patch('pandas.io.formats.console.get_terminal_size', | ||
return_value=terminal_size) | ||
p2 = mock.patch('pandas.io.formats.format.get_terminal_size', | ||
return_value=terminal_size) | ||
|
||
index = range(5) | ||
columns = pd.MultiIndex.from_tuples([ | ||
('This is a long title with > 37 chars.', 'cat'), | ||
('This is a loooooonger title with > 43 chars.', 'dog'), | ||
]) | ||
df = pd.DataFrame(1, index=index, columns=columns) | ||
|
||
with p1, p2: | ||
result = repr(df) | ||
|
||
h1, h2 = result.split('\n')[:2] | ||
assert 'long' in h1 | ||
assert 'loooooonger' in h1 | ||
assert 'cat' in h2 | ||
assert 'dog' in h2 | ||
|
||
# regular columns | ||
df2 = pd.DataFrame({"A" * 41: [1, 2], 'B' * 41: [1, 2]}) | ||
with p1, p2: | ||
result = repr(df2) | ||
|
||
assert df2.columns[0] in result.split('\n')[0] | ||
|
||
def test_repr_max_columns_max_rows(self): | ||
term_width, term_height = get_terminal_size() | ||
if term_width < 10 or term_height < 10: | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe make make the comments consistent here