TST: Refactor test_maybe_match_name and test_hash_pandas_object #21600
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minggli
changed the title
WillAyd
approved these changes
Jun 22, 2018
Codecov Report
@@ Coverage Diff @@
## master #21600 +/- ##
=======================================
Coverage 91.9% 91.9%
=======================================
Files 153 153
Lines 49548 49548
=======================================
Hits 45538 45538
Misses 4010 4010
Continue to review full report at Codecov.
|
minggli
changed the title
|
Hello @minggli! Thanks for updating the PR. Cheers ! There are no PEP8 issues in this Pull Request. 🍻 Comment last updated on June 23, 2018 at 07:48 Hours UTC |
minggli
force-pushed
the
refactor/test_common
branch
from
0381203 to
2ddd15c
Compare
WillAyd
reviewed
Jun 23, 2018
| pd.date_range('20130101', periods=2)]), | ||
| MultiIndex.from_product([pd.CategoricalIndex(list('aabc')), range(3)]) | ||
| ]) | ||
| def test_hash_pandas_object(self, obj): |
There was a problem hiding this comment.
Was anything changed here besides indentation?
There was a problem hiding this comment.
no, just indentation.
|
@WillAyd further comments welcome. |
|
lgtm - thanks! |
gfyoung
approved these changes
Jun 25, 2018
gfyoung
added
Testing
|
thanks @minggli ! keep em coming! |
|
thanks for reviewing. |
Sup3rGeo
pushed a commit
to Sup3rGeo/pandas
that referenced
this pull request
Oct 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master -u -- "*.py" | flake8 --diff