Skip to content

clarifying regex pipe behavior #21589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 22, 2018
Merged

Conversation

mitchnegus
Copy link
Contributor

Current documentation for pandas.Series.str.contains() states that the | acts as a regex and operator ("Returning ‘house’ and ‘parrot’ within same string."), while I believe it is actually an or operator. I've updated the phrase and example to demonstrate this behavior in what I think is a clearer way, though I'm definitely open to suggestions to improve it further.

  • closes #xxxx
  • tests added / passed
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

@gfyoung gfyoung added the Docs label Jun 22, 2018
@gfyoung gfyoung requested a review from jreback June 22, 2018 08:34
@codecov
Copy link

codecov bot commented Jun 22, 2018

Codecov Report

Merging #21589 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #21589      +/-   ##
==========================================
+ Coverage    91.9%    91.9%   +<.01%     
==========================================
  Files         153      153              
  Lines       49549    49549              
==========================================
+ Hits        45537    45539       +2     
+ Misses       4012     4010       -2
Flag Coverage Δ
#multiple 90.3% <ø> (ø) ⬆️
#single 41.78% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/strings.py 98.62% <ø> (ø) ⬆️
pandas/util/testing.py 85.27% <0%> (+0.2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1ffc5f...1620c59. Read the comment docs.

@jreback jreback added this to the 0.24.0 milestone Jun 22, 2018
@jreback jreback merged commit c2b03e4 into pandas-dev:master Jun 22, 2018
@jreback
Copy link
Contributor

jreback commented Jun 22, 2018

thanks, yeah this was a typo

Sup3rGeo pushed a commit to Sup3rGeo/pandas that referenced this pull request Oct 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants