DOC: Adding clarification on return dtype of to_numeric #21585
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specifying the default return types for `to_numeric` in case of no downcast
Codecov Report
@@ Coverage Diff @@
## master #21585 +/- ##
==========================================
+ Coverage 91.9% 91.9% +<.01%
==========================================
Files 153 153
Lines 49549 49549
==========================================
+ Hits 45537 45539 +2
+ Misses 4012 4010 -2
Continue to review full report at Codecov.
|
gfyoung
added
Docs
Dtype Conversions
jorisvandenbossche
changed the title
pandas/core/tools/numeric.py
Outdated
| @@ -43,6 +43,10 @@ def to_numeric(arg, errors='raise', downcast=None): | |||
| checked satisfy that specification, no downcasting will be | |||
| performed on the data. | |||
|
|
|||
| Also Note that the default return dtype is `float64` or `int64` | |||
| depending on the data supplied.`downcast` for `float` or `int` | |||
| should only be used if output desired is `float32` or `int32` | |||
There was a problem hiding this comment.
I would maybe add something like this to the "extended summary" (just after the first line of the docstring), so something like:
Convert argument to a numeric type.
The default return dtype is `float64` or `int64` depending on the data supplied.
Use the `downcast` parameter to obtain other dtypes.
Parameters
-----------
...
There was a problem hiding this comment.
@jorisvandenbossche Sure, I will modify the PR asap
Adding the explanation in extended summary
|
Hello @uds5501! Thanks for updating the PR. Cheers ! There are no PEP8 issues in this Pull Request. 🍻 Comment last updated on June 22, 2018 at 10:05 Hours UTC |
|
thanks! |
Sup3rGeo
pushed a commit
to Sup3rGeo/pandas
that referenced
this pull request
Oct 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifying the default return types for
to_numericin case of no downcastgit diff upstream/master -u -- "*.py" | flake8 --diff