Skip to content

DOC: Note assert_almost_equal impl. detail #21580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 22, 2018
Merged

DOC: Note assert_almost_equal impl. detail #21580

merged 1 commit into from
Jun 22, 2018

Conversation

gfyoung
Copy link
Member

@gfyoung gfyoung commented Jun 21, 2018 •
edited
Loading

Note the hard-coded switch between absolute and relative tolerance during checking.

Closes #21528.

@gfyoung
DOC: Note assert_almost_equal impl. detail
0f4d201 
Note the hard-coded switch between absolute
and relative tolerance during checking.

Closes pandas-devgh-21528.
@gfyoung gfyoung added Testing pandas testing functions or related to the test suite Docs labels Jun 21, 2018
@gfyoung gfyoung added this to the 0.24.0 milestone Jun 21, 2018
@codecov
Copy link

codecov bot commented Jun 22, 2018 •
edited
Loading

Codecov Report

Merging #21580 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #21580   +/-   ##
=======================================
  Coverage    91.9%    91.9%           
=======================================
  Files         153      153           
  Lines       49549    49549           
=======================================
  Hits        45537    45537           
  Misses       4012     4012
Flag Coverage Δ
#multiple 90.3% <ø> (ø) ⬆️
#single 41.78% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/util/testing.py 85.06% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1ffc5f...0f4d201. Read the comment docs.

@jreback jreback merged commit ac56856 into pandas-dev:master Jun 22, 2018
@jreback
Copy link
Contributor

jreback commented Jun 22, 2018

thanks!

@gfyoung gfyoung deleted the testing-almost-equal-docs branch June 22, 2018 16:52
Sup3rGeo pushed a commit to Sup3rGeo/pandas that referenced this pull request Oct 1, 2018
@gfyoung
DOC: Note assert_almost_equal impl. detail (pandas-dev#21580)
9edace0 
Note the hard-coded switch between absolute
and relative tolerance during checking.

Closes pandas-devgh-21528.
@qris qris mentioned this pull request Apr 15, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Docs Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
0.24.0
Development

Successfully merging this pull request may close these issues.
2 participants
@gfyoung @jreback