Skip to content

remove daytime attr, move getstate and setstate to base class #21533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 19, 2018

Conversation

jbrockmendel
Copy link
Member

If/when #18224 is revived to make _BaseOffset a cdef class, we'll need to move __getstate__ and __setstate__ into the base class (and then make some changes). This moves the two methods pre-emptively so that we'll have a smaller diff for the next steps.

Also removes an attr self.daytime that is not used anywhere else.

@jreback jreback added Frequency DateOffsets Clean labels Jun 19, 2018
@jreback
Copy link
Contributor

jreback commented Jun 19, 2018

lgtm. ping on green.

@jreback jreback added this to the 0.24.0 milestone Jun 19, 2018
@codecov
Copy link

codecov bot commented Jun 19, 2018

Codecov Report

Merging #21533 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #21533      +/-   ##
==========================================
- Coverage   91.92%   91.92%   -0.01%     
==========================================
  Files         153      153              
  Lines       49594    49570      -24     
==========================================
- Hits        45590    45566      -24     
  Misses       4004     4004
Flag Coverage Δ
#multiple 90.32% <ø> (-0.01%) ⬇️
#single 41.81% <ø> (-0.02%) ⬇️
Impacted Files Coverage Δ
pandas/tseries/offsets.py 97.19% <ø> (-0.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6131a59...5c6dfbb. Read the comment docs.

@jreback
Copy link
Contributor

jreback commented Jun 19, 2018

thanks!

@jreback jreback merged commit 27f7c2b into pandas-dev:master Jun 19, 2018
@jbrockmendel jbrockmendel deleted the states branch June 22, 2018 03:27
Sup3rGeo pushed a commit to Sup3rGeo/pandas that referenced this pull request Oct 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants