fixed unicode issue (21499) using requests library #21532
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @hannahmendez! Thanks for updating the PR.
Comment last updated on June 18, 2018 at 19:04 Hours UTC |
|
My guess is that #21504 could supersede this one. I'll add tests soon. I have a limited time I can work on this. (And I'm waiting for the docstrings questions I asked there before continuing 😄). |
ocefpaf
reviewed
Jun 18, 2018
| @@ -127,8 +127,8 @@ def _read(obj): | |||
| raw_text : str | |||
| """ | |||
| if _is_url(obj): | |||
| with urlopen(obj) as url: | |||
|
Closing in favor of #21504 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master -u -- "*.py" | flake8 --diff