Skip to content

PERF: remove useless overrides #21523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 18, 2018
Merged

Conversation

toobaz
Copy link
Member

@toobaz toobaz commented Jun 18, 2018

Asv run:

       before           after         ratio
     [9e982e18]       [705f0e3b]
-         243±7ms          186±4ms     0.77  multiindex_object.GetLoc.time_large_get_loc_warm
-       220±0.9ms          151±3ms     0.69  multiindex_object.GetLoc.time_large_get_loc
-         173±1ms          101±2ms     0.59  multiindex_object.Integer.time_get_indexer

SOME BENCHMARKS HAVE CHANGED SIGNIFICANTLY.

Notice that as of now the same cannot be done for .is_monotonic_increasing and friends, because the sortedness of the MultiIndex corresponds to the sortedness of the underlying int index only if levels are themselves sorted.

@toobaz toobaz added Performance Memory or execution speed performance MultiIndex labels Jun 18, 2018
@codecov
Copy link

codecov bot commented Jun 18, 2018

Codecov Report

Merging #21523 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #21523      +/-   ##
==========================================
- Coverage   91.92%   91.92%   -0.01%     
==========================================
  Files         153      153              
  Lines       49587    49583       -4     
==========================================
- Hits        45583    45579       -4     
  Misses       4004     4004
Flag Coverage Δ
#multiple 90.32% <ø> (-0.01%) ⬇️
#single 41.83% <ø> (-0.06%) ⬇️
Impacted Files Coverage Δ
pandas/core/indexes/multi.py 94.97% <ø> (-0.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e982e1...131a7c3. Read the comment docs.

@jreback jreback added this to the 0.23.2 milestone Jun 18, 2018
@jreback jreback merged commit ea54d39 into pandas-dev:master Jun 18, 2018
@jreback
Copy link
Contributor

jreback commented Jun 18, 2018

thanks!

@toobaz toobaz deleted the del_mi_overrides branch June 18, 2018 21:45
jorisvandenbossche pushed a commit that referenced this pull request Jun 29, 2018
closes #21522
(cherry picked from commit ea54d39)
jorisvandenbossche pushed a commit that referenced this pull request Jul 2, 2018
closes #21522
(cherry picked from commit ea54d39)
Sup3rGeo pushed a commit to Sup3rGeo/pandas that referenced this pull request Oct 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MultiIndex Performance Memory or execution speed performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MultiIndex.is_unique is unbearably slow
3 participants