Skip to content

read_html: Handle colspan and rowspan #21487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Jul 5, 2018
Merged

read_html: Handle colspan and rowspan #21487

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
3e58794
Handle colspan and rowspan
adamhooper Jun 14, 2018
f89b32a
Fixes after code review -- thanks, @WillAyd
adamhooper Jun 15, 2018
34f87cb
Docstring tweaks
adamhooper Jun 15, 2018
582c86b
Details -- thanks, @jreback
adamhooper Jun 15, 2018
d2f0b83
Tweak comments
adamhooper Jun 15, 2018
74c2384
Address latest review comments from @WillAyd
adamhooper Jun 15, 2018
ad6e869
Clean up html tests
adamhooper Jun 21, 2018
6fa0489
Do not nix rows of empty
adamhooper Jun 21, 2018
86b2dea
Merge branch 'master' into colspan-rowspan
adamhooper Jul 2, 2018
d4f4bb1
Comments: Notes after Returns
adamhooper Jul 3, 2018
e296bd1
Document read_html changes in whatsnew
adamhooper Jul 4, 2018
f0f91c3
Merge branch 'master' into colspan-rowspan
adamhooper Jul 4, 2018
95ce993
Improve whatsnew with ipython
adamhooper Jul 4, 2018
5fd863b
fixup whatsnew
jreback Jul 5, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion doc/source/whatsnew/v0.24.0.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ Other Enhancements
<https://pandas-gbq.readthedocs.io/en/latest/changelog.html#changelog-0-5-0>`__.
(:issue:`21627`)
- New method :meth:`HDFStore.walk` will recursively walk the group hierarchy of an HDF5 file (:issue:`10932`)
- :func:`read_html` copies cell data across ``colspan``s and ``rowspan``s, and it treats all-``th`` table rows as headers if ``header`` kwarg is not given and there is no ``thead`` (:issue:`17054`)
- :meth:`Series.nlargest`, :meth:`Series.nsmallest`, :meth:`DataFrame.nlargest`, and :meth:`DataFrame.nsmallest` now accept the value ``"all"`` for the ``keep` argument. This keeps all ties for the nth largest/smallest value (:issue:`16818`)
-

Expand Down Expand Up @@ -297,7 +298,7 @@ MultiIndex
I/O
^^^

-
- :func:`read_html()` no longer ignores all-whitespace ``<tr>`` within ``<thead>`` when considering the ``skiprows`` and ``header`` arguments. Previously, users had to decrease their ``header`` and ``skiprows`` values on such tables to work around the issue. (:issue:`21641`)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is all ok, but would a subsection with a mini-example be instructive to the user about the revised functinaility? not saying 100% need to, but if a simple enough example (or even an image) would be helpful here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to display my ignorance of the whatsnew format: ... where would this go?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, you make a new subsection in the top somewhere, e.g. model after this

Series and Index Data-Dtype Incompatibilities

just add a new one below and you can make an extended example

-
-

Expand Down
Loading