Skip to content

BUG: Timedelta.__bool__ #21485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 18, 2018
Merged

BUG: Timedelta.__bool__ #21485

merged 3 commits into from
Jun 18, 2018

Conversation

TomAugspurger
Copy link
Contributor

Closes #21484

@TomAugspurger TomAugspurger added this to the 0.23.2 milestone Jun 14, 2018
@TomAugspurger TomAugspurger added the Timedelta Timedelta data type label Jun 14, 2018
@codecov
Copy link

codecov bot commented Jun 14, 2018 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@89418a3). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #21485   +/-   ##
=========================================
  Coverage          ?   91.89%           
=========================================
  Files             ?      153           
  Lines             ?    49604           
  Branches          ?        0           
=========================================
  Hits              ?    45586           
  Misses            ?     4018           
  Partials          ?        0
Flag Coverage Δ
#multiple 90.3% <ø> (?)
#single 41.88% <ø> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89418a3...bd595a5. Read the comment docs.

jreback
jreback requested changes Jun 15, 2018
View reviewed changes
pandas/tests/scalar/timedelta/test_timedelta.py

@pytest.mark.parametrize('value, expected', [
(Timedelta('10S'), True),
(Timedelta('-10S'), True),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add 0S here

doc/source/whatsnew/v0.23.2.txt Outdated
@@ -82,4 +82,5 @@ Bug Fixes

**Other**

- Bug in :class:`Timedelta` where non-zero timedeltas shorter than 1 microsecond were considered False (:issue:`21484`)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you make a Datetimelike section (or Timedelta ok too)

@jreback
Copy link
Contributor

jreback commented Jun 15, 2018

minor comments, lgtm otherwise.

@jreback jreback merged commit d5a1232 into pandas-dev:master Jun 18, 2018
@jreback
Copy link
Contributor

jreback commented Jun 18, 2018

thanks @TomAugspurger

jorisvandenbossche pushed a commit that referenced this pull request Jun 29, 2018
@TomAugspurger @jorisvandenbossche
BUG: Timedelta.__bool__ (#21485)
e1736f9 
Closes #21484

(cherry picked from commit d5a1232)
jorisvandenbossche pushed a commit that referenced this pull request Jul 2, 2018
@TomAugspurger @jorisvandenbossche
BUG: Timedelta.__bool__ (#21485)
76551c2 
Closes #21484

(cherry picked from commit d5a1232)
Sup3rGeo pushed a commit to Sup3rGeo/pandas that referenced this pull request Oct 1, 2018
@TomAugspurger
BUG: Timedelta.__bool__ (pandas-dev#21485)
445f625 
Closes pandas-dev#21484
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
Timedelta Timedelta data type
Projects
None yet
Milestone
0.23.2
Development

Successfully merging this pull request may close these issues.
3 participants
@TomAugspurger @jreback @jorisvandenbossche